Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Change ExtensionConfig to Cluster scoped #6547

Conversation

killianmuldoon
Copy link
Contributor

@killianmuldoon killianmuldoon commented May 25, 2022

Signed-off-by: killianmuldoon [email protected]

Update types and runtimeSDK proposal to make the ExtensionConfig Cluster scoped. This was the intention from the design stage, but was never explicit in the proposal, and was incorrectly implemented in the initial version of the type.

/area runtime-sdk

@k8s-ci-robot k8s-ci-robot added area/runtime-sdk Issues or PRs related to Runtime SDK cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 25, 2022
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 25, 2022
@killianmuldoon killianmuldoon changed the title Change ExtensionConfig to Cluster scoped 🌱 Change ExtensionConfig to Cluster scoped May 25, 2022
@killianmuldoon killianmuldoon force-pushed the runtime-SDK/extension-config-scope branch from 5f3276f to c726a11 Compare May 25, 2022 14:33
@killianmuldoon killianmuldoon force-pushed the runtime-SDK/extension-config-scope branch from c726a11 to 92f5e9a Compare May 25, 2022 14:42
@sbueringer
Copy link
Member

/lgtm

Nice catch, good that we talked about it :)

/assign @fabriziopandini

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 25, 2022
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2022
@enxebre
Copy link
Member

enxebre commented May 26, 2022

does this mean extensions can't be scoped to clusters in a given namespace?

@k8s-ci-robot k8s-ci-robot merged commit a425d76 into kubernetes-sigs:main May 26, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.2 milestone May 26, 2022
@sbueringer
Copy link
Member

sbueringer commented May 27, 2022

does this mean extensions can't be scoped to clusters in a given namespace?

They can be scoped via the namespaceSelector in the ExtensionConfig. It's the same as with MutatingWebhookConfiguration / ValidatingWebhookConfiguration, the CRD itself is cluster-wide but then you can filter via namespaceSelector.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/runtime-sdk Issues or PRs related to Runtime SDK cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants