-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Change ExtensionConfig to Cluster scoped #6547
🌱 Change ExtensionConfig to Cluster scoped #6547
Conversation
5f3276f
to
c726a11
Compare
Signed-off-by: killianmuldoon <[email protected]>
c726a11
to
92f5e9a
Compare
/lgtm Nice catch, good that we talked about it :) /assign @fabriziopandini |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
does this mean extensions can't be scoped to clusters in a given namespace? |
They can be scoped via the namespaceSelector in the ExtensionConfig. It's the same as with MutatingWebhookConfiguration / ValidatingWebhookConfiguration, the CRD itself is cluster-wide but then you can filter via namespaceSelector. |
Signed-off-by: killianmuldoon [email protected]
Update types and runtimeSDK proposal to make the ExtensionConfig Cluster scoped. This was the intention from the design stage, but was never explicit in the proposal, and was incorrectly implemented in the initial version of the type.
/area runtime-sdk