Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 update supported Kubernetes versions #6543

Merged

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented May 25, 2022

Signed-off-by: Stefan Büringer [email protected]

What this PR does / why we need it:
Update supported versions in the book to include 1.24.
I refactored the table a bit to improve readability + to be able to include v1.24 without adding another two columns.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #5968
Fixes #6155

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 25, 2022
@sbueringer
Copy link
Member Author

/hold
until #6513 is merged

/cherry-pick release-1.1

@k8s-infra-cherrypick-robot

@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.1 in a new PR and assign it to you.

In response to this:

/hold
until #6513 is merged

/cherry-pick release-1.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 25, 2022
@sbueringer sbueringer mentioned this pull request May 25, 2022
33 tasks
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retitle 📖 update supported Kubernetes versions
/lgtm

Aside - not a blocker - are we planning to drop 0.3/0.4/1.0 from the main version of the book ahead of the next release?

@k8s-ci-robot k8s-ci-robot changed the title 📖 book: update supported Kubernetes versions 📖 update supported Kubernetes versions May 27, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 27, 2022
@sbueringer
Copy link
Member Author

I'll use this PR to test some jobs (in addition to testgrid as the update test there run only once per day):

/test pull-cluster-api-e2e-workload-upgrade-1-24-latest-main
/test pull-cluster-api-e2e-full-main

@k8s-ci-robot
Copy link
Contributor

@sbueringer: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-e2e-workload-upgrade-1-24-latest-main d626b5c link false /test pull-cluster-api-e2e-workload-upgrade-1-24-latest-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sbueringer
Copy link
Member Author

sbueringer commented May 27, 2022

Aside - not a blocker - are we planning to drop 0.3/0.4/1.0 from the main version of the book ahead of the next release?

I don't know. On one side those versions are all out of support. On the other side we only kept the version page of the current book up-to-date. This means that we might lose the information which Kubernetes version we support in which CAPI version if we just drop it here (not sure, but we can verify the old books).

@sbueringer
Copy link
Member Author

/hold cancel
/assign @fabriziopandini
Test failure is obviously unrelated and will be fixed elsewhere.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 27, 2022
@chrischdi
Copy link
Member

/lgtm

@sbueringer sbueringer force-pushed the pr-update-supported-versions branch from d626b5c to 908822a Compare May 30, 2022 08:41
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 30, 2022
@sbueringer
Copy link
Member Author

Added notes about labels/taints and criSocket

@sbueringer sbueringer force-pushed the pr-update-supported-versions branch from 908822a to c0b9e52 Compare May 30, 2022 08:53
@enxebre
Copy link
Member

enxebre commented May 31, 2022

@sbueringer are we currently running tests for kube >= 1.18?

@sbueringer
Copy link
Member Author

sbueringer commented May 31, 2022

@sbueringer are we currently running tests for kube >= 1.18?

We have one test where we install v1.18, then upgrade to v1.19 and then run conformance tests.

Most versions that we claim we have support for are only tested by upgrade tests. (https://testgrid.k8s.io/sig-cluster-lifecycle-cluster-api).

We only run more tests for v1.19 (min) and v1.24 (max) management clusters (e.g. capi-e2e-main uses v1.24, capi-e2e-mink8s-main uses v1.19). Those tests are using v1.24 as workload cluster version (and v1.23=>v1.24 for the upgrade).

@fabriziopandini
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 3, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 3, 2022
@k8s-ci-robot k8s-ci-robot merged commit 7077ef3 into kubernetes-sigs:main Jun 3, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.2 milestone Jun 3, 2022
@k8s-infra-cherrypick-robot

@sbueringer: new pull request created: #6592

In response to this:

/hold
until #6513 is merged

/cherry-pick release-1.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbueringer sbueringer deleted the pr-update-supported-versions branch June 3, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use socket with unix:/// in CAPD.
7 participants