-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 update supported Kubernetes versions #6543
📖 update supported Kubernetes versions #6543
Conversation
/hold /cherry-pick release-1.1 |
@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.1 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/retitle 📖 update supported Kubernetes versions
/lgtm
Aside - not a blocker - are we planning to drop 0.3/0.4/1.0 from the main version of the book ahead of the next release?
I'll use this PR to test some jobs (in addition to testgrid as the update test there run only once per day): /test pull-cluster-api-e2e-workload-upgrade-1-24-latest-main |
@sbueringer: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
I don't know. On one side those versions are all out of support. On the other side we only kept the version page of the current book up-to-date. This means that we might lose the information which Kubernetes version we support in which CAPI version if we just drop it here (not sure, but we can verify the old books). |
/hold cancel |
/lgtm |
d626b5c
to
908822a
Compare
Added notes about labels/taints and criSocket |
Signed-off-by: Stefan Büringer [email protected]
908822a
to
c0b9e52
Compare
@sbueringer are we currently running tests for kube >= 1.18? |
We have one test where we install v1.18, then upgrade to v1.19 and then run conformance tests. Most versions that we claim we have support for are only tested by upgrade tests. (https://testgrid.k8s.io/sig-cluster-lifecycle-cluster-api). We only run more tests for v1.19 (min) and v1.24 (max) management clusters (e.g. capi-e2e-main uses v1.24, capi-e2e-mink8s-main uses v1.19). Those tests are using v1.24 as workload cluster version (and v1.23=>v1.24 for the upgrade). |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@sbueringer: new pull request created: #6592 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Stefan Büringer [email protected]
What this PR does / why we need it:
Update supported versions in the book to include 1.24.
I refactored the table a bit to improve readability + to be able to include v1.24 without adding another two columns.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Part of #5968
Fixes #6155