Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Add basic overview doc and feature flags #6538

Merged

Conversation

killianmuldoon
Copy link
Contributor

Signed-off-by: killianmuldoon [email protected]

Add the Runtime SDK feature flag in a couple of places in the docs and add a small experimental feature doc on how to enable it.

Fixes #6384

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 24, 2022
@killianmuldoon killianmuldoon changed the title Add basic overview doc and feature flags 📖 Add basic overview doc and feature flags May 24, 2022
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 24, 2022
@killianmuldoon killianmuldoon force-pushed the runtime-sdk/basic-first-docs branch from 0b3d938 to 4f0f3db Compare May 24, 2022 14:59
Copy link
Contributor Author

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/area runtime-sdk

@k8s-ci-robot k8s-ci-robot added the area/runtime-sdk Issues or PRs related to Runtime SDK label May 24, 2022
@killianmuldoon killianmuldoon force-pushed the runtime-sdk/basic-first-docs branch from 4f0f3db to e37ead9 Compare May 24, 2022 15:06
@@ -0,0 +1,12 @@
# Experimental Feature: Runtime SDK

The Runtime SDK feature provides an extensibility mechanism that allows systems, products, and services built on top of Cluster API to hook into a workload cluster’s lifecycle.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure how specific we want to be here, e.g. may be mention available Runtime Hook and particular Runtime Extensions

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is definitely a work in progress just to get us started. My plan was to add documentation piece by piece as we add in some of the particular hooks, and hopefully add in some examples of extensions as they get developed and published.

Copy link
Member

@sbueringer sbueringer May 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for now the current description is fine.

I think we should extend the documentation once the hooks are merged similar to how we did it with ClusterClass.

I expect us to have at least one additional page describing the cluster lifecycle hooks and one for topology mutation with user facing documentation. (I added a sub-task for book documentation to the umbrella issues of the hooks)

@enxebre
Copy link
Member

enxebre commented May 25, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 25, 2022
@@ -0,0 +1,12 @@
# Experimental Feature: Runtime SDK

The Runtime SDK feature provides an extensibility mechanism that allows systems, products, and services built on top of Cluster API to hook into a workload cluster’s lifecycle.
Copy link
Member

@sbueringer sbueringer May 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for now the current description is fine.

I think we should extend the documentation once the hooks are merged similar to how we did it with ClusterClass.

I expect us to have at least one additional page describing the cluster lifecycle hooks and one for topology mutation with user facing documentation. (I added a sub-task for book documentation to the umbrella issues of the hooks)

@sbueringer sbueringer mentioned this pull request May 25, 2022
30 tasks
@killianmuldoon killianmuldoon force-pushed the runtime-sdk/basic-first-docs branch from e37ead9 to cddde1c Compare May 25, 2022 14:55
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 25, 2022
@killianmuldoon killianmuldoon force-pushed the runtime-sdk/basic-first-docs branch from cddde1c to 9e31a2d Compare May 25, 2022 14:56
@sbueringer
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 25, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 25, 2022
@k8s-ci-robot k8s-ci-robot merged commit fe58ae2 into kubernetes-sigs:main May 25, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.2 milestone May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/runtime-sdk Issues or PRs related to Runtime SDK cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Propogate RuntimeSDK feature flag in docs
4 participants