-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Add basic overview doc and feature flags #6538
📖 Add basic overview doc and feature flags #6538
Conversation
0b3d938
to
4f0f3db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/area runtime-sdk
4f0f3db
to
e37ead9
Compare
@@ -0,0 +1,12 @@ | |||
# Experimental Feature: Runtime SDK | |||
|
|||
The Runtime SDK feature provides an extensibility mechanism that allows systems, products, and services built on top of Cluster API to hook into a workload cluster’s lifecycle. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure how specific we want to be here, e.g. may be mention available Runtime Hook and particular Runtime Extensions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is definitely a work in progress just to get us started. My plan was to add documentation piece by piece as we add in some of the particular hooks, and hopefully add in some examples of extensions as they get developed and published.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think for now the current description is fine.
I think we should extend the documentation once the hooks are merged similar to how we did it with ClusterClass.
I expect us to have at least one additional page describing the cluster lifecycle hooks and one for topology mutation with user facing documentation. (I added a sub-task for book documentation to the umbrella issues of the hooks)
/lgtm |
@@ -0,0 +1,12 @@ | |||
# Experimental Feature: Runtime SDK | |||
|
|||
The Runtime SDK feature provides an extensibility mechanism that allows systems, products, and services built on top of Cluster API to hook into a workload cluster’s lifecycle. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think for now the current description is fine.
I think we should extend the documentation once the hooks are merged similar to how we did it with ClusterClass.
I expect us to have at least one additional page describing the cluster lifecycle hooks and one for topology mutation with user facing documentation. (I added a sub-task for book documentation to the umbrella issues of the hooks)
e37ead9
to
cddde1c
Compare
Signed-off-by: killianmuldoon <[email protected]>
cddde1c
to
9e31a2d
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: killianmuldoon [email protected]
Add the Runtime SDK feature flag in a couple of places in the docs and add a small experimental feature doc on how to enable it.
Fixes #6384