-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Silence error in go_install.sh when trying to remove nonexisting files #6532
🌱 Silence error in go_install.sh when trying to remove nonexisting files #6532
Conversation
Welcome @oscr! |
Hi @oscr. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@@ -37,7 +37,7 @@ if [ -z "${GOBIN}" ]; then | |||
exit 1 | |||
fi | |||
|
|||
rm "${GOBIN}/${2}"* || true | |||
rm -f "${GOBIN}/${2}"* || true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks okay to me for this script/context, though I don't know if using the force flag is the best way to do this overall.
Could we redirect the output instead of using the force flag?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used force because it was consistent with how it's used other places in the project. However I can absolutely change it if you'd like. Would you prefer a redirect instead @killianmuldoon?
/ok-to-test |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Silences the
No such file or directory
message when runningmake test
in a new repo or after runningmake clean
to reduce noise.On my machine: