✨clusterctl upgrade apply: wait for providers to be ready

[praveenrewar]

What this PR does / why we need it:
clusterctl upgrade apply should wait for the cluster to be 'ready' before exiting.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #6267

[k8s-ci-robot]

Hi @praveenrewar. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ykakarap]

@praveenrewar Thank you for working on this! 🚀

I am LGTM with the overall approach. I will take another look after we have more information about the breaking API change.

[ykakarap]

/ok-to-test

[sbueringer]

Just a few nits, otherwise lgtm from my side

P.S. Yuvaraj commented on them before as well, did you maybe only forget to push a commit?

[praveenrewar]

P.S. Yuvaraj commented on them before as well, did you maybe only forget to push a commit?

Oops, my bad. Good catch! Thanks :)

[praveenrewar]

From the issue:

Additional note: After this feature is implemented there we can probably refactor some our e2e tests to remove the wait logic and instead just call the upgrade command with the corresponding wait flags

Should I update the e2e tests as part of the same PR or does it make sense to have a separate PR for it?
(I am leaning towards making the change in this PR itself but okay with both the options)

[sbueringer]

Oops, my bad. Good catch! Thanks :)

Thx for the quick fix :).

Should I update the e2e tests as part of the same PR or does it make sense to have a separate PR for it? (I am leaning towards making the change in this PR itself but okay with both the options)

I would suggest to make it a separate PR. I think this PR now would be ready for a final review from someone else + merge.

Can you please squash the commits? We're running Prow in merge mode for our release notes tool, so we have to merge manually on the PRs ourselves. (apart from squash, lgtm from my side)

[praveenrewar]

I would suggest to make it a separate PR. I think this PR now would be ready for a final review from someone else + merge.

Cool 👍🏻

Can you please squash the commits?

Sure, done :)

[k8s-ci-robot]

@praveenrewar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cluster-api-apidiff-main	1bb1142	link	false	/test pull-cluster-api-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[sbueringer]

Thx!

/lgtm
/assign @ykakarap

[praveenrewar]

Hey @ykakarap, do let me know if anything else is required on this PR :)

[sbueringer]

/assign @fabriziopandini
for a final look

[chrischdi]

/lgtm

[ykakarap]

/lgtm

Should I update the e2e tests as part of the same PR or does it make sense to have a separate PR for it?
(I am leaning towards making the change in this PR itself but okay with both the options)

A separate PR for that would be ideal.

[sbueringer]

/lgtm
/approve

/cherry-pick release-1.2

[k8s-infra-cherrypick-robot]

@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.2 in a new PR and assign it to you.

In response to this:

/lgtm
/approve

/cherry-pick release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-infra-cherrypick-robot]

@sbueringer: new pull request created: #6685

In response to this:

/lgtm
/approve

/cherry-pick release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.