Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 book: Add note about Tiltfile syntax highlighting #6463

Merged
merged 1 commit into from
May 3, 2022
Merged

📖 book: Add note about Tiltfile syntax highlighting #6463

merged 1 commit into from
May 3, 2022

Conversation

sbueringer
Copy link
Member

Signed-off-by: Stefan Büringer [email protected]

What this PR does / why we need it:
Adds documentation about Tiltfile syntax highlighting.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 29, 2022
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 29, 2022
@stmcginnis
Copy link
Contributor

/lgtm

I did a quick search on VSCode textmate bundle support. There are a few packages that add TextMate support, but it didn't look like it could be used with this. Maybe someone can check it out closer than I have.

Even if this is only an option for the JetBrains users, it would be great to add.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 29, 2022
@sbueringer
Copy link
Member Author

sbueringer commented Apr 29, 2022 •
edited
Loading

/lgtm

I did a quick search on VSCode textmate bundle support. There are a few packages that add TextMate support, but it didn't look like it could be used with this. Maybe someone can check it out closer than I have.

Even if this is only an option for the JetBrains users, it would be great to add.

Naadir just told me that for VSCode the Bazel plugin works and also provides auto-linting. I'll update accordingly

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 29, 2022
sbueringer
sbueringer commented Apr 29, 2022
View reviewed changes
docs/book/src/developer/tilt.md

For Intellij, Syntax highlighting for the Tiltfile can be configured with a TextMate Bundle. For instructions, please see:
[Tiltfile TextMate Bundle](https://github.com/tilt-dev/tiltfile.tmbundle).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Credit to @randomvariable for the info about the Bazel plugin

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

np. lgtm.

@stmcginnis
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 29, 2022
chrischdi
chrischdi reviewed Apr 29, 2022
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Works great :-)

killianmuldoon
killianmuldoon approved these changes May 3, 2022
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

vincepri
vincepri approved these changes May 3, 2022
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 3, 2022
@k8s-ci-robot k8s-ci-robot merged commit e77f474 into kubernetes-sigs:main May 3, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.2 milestone May 3, 2022
@sbueringer sbueringer deleted the pr-tilt-syntax branch May 10, 2022 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@randomvariable randomvariable randomvariable left review comments

@chrischdi chrischdi chrischdi left review comments

@killianmuldoon killianmuldoon killianmuldoon approved these changes

@vincepri vincepri vincepri approved these changes

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@stmcginnis stmcginnis Awaiting requested review from stmcginnis

Assignees

@chrischdi chrischdi

@stmcginnis stmcginnis

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.
7 participants
@sbueringer @stmcginnis @k8s-ci-robot @chrischdi @randomvariable @vincepri @killianmuldoon