🌱 Replace deprecated strings.Title with cases.Title #6453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
stmcginnis
force-pushed
the
stringsTitle
branch
from
14c7118 to
103bb20
Compare
sbueringer
reviewed
Apr 27, 2022
|
lgtm pending happy linter |
The strings.Title function is being deprecated in Go 1.18 due to issues with its handling of certain unicode sets. The recommended replacement is cases.Title. We only have one location where this was being used in a utility function. This updates that instance to use the new recommendations. https://tip.golang.org/doc/go1.18#minor_library_changes Signed-off-by: Sean McGinnis <[email protected]>
stmcginnis
force-pushed
the
stringsTitle
branch
from
103bb20 to
32028f3
Compare
|
Thank you very much! /lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The strings.Title function is being deprecated in Go 1.18 due to issues
with its handling of certain unicode sets. The recommended replacement
is cases.Title.
We only have one location where this was being used in a utility
function. This updates that instance to use the new recommendations.
https://tip.golang.org/doc/go1.18#minor_library_changes