🌱 Update promote-images to filter by image and sort by tag #6452
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
| @@ -40,6 +40,6 @@ fi | |||
| rm "${GOBIN}/${2}"* || true | |||
|
|
|||
| # install the golang module specified as the first argument | |||
| go install -tags tools "${1}@${3}" | |||
There was a problem hiding this comment.
I'm not sure why this was needed, pretty sure it was there at the time we had fake go.mod but is no longer needed. I removed it because it was causing errors due to a conflict with a new imported package in kpromo:
../../../pkg/mod/github.com/google/[email protected]/tools.go:20:2: import "github.com/fullstorydev/grpcurl/cmd/grpcurl" is a program, not an importable package
because the above has tag // +build tools
There was a problem hiding this comment.
I agree, probably we probably copied the command from there
|
/assign @sbueringer @fabriziopandini |
CecileRobertMichon
changed the title
| @@ -40,6 +40,6 @@ fi | |||
| rm "${GOBIN}/${2}"* || true | |||
|
|
|||
| # install the golang module specified as the first argument | |||
| go install -tags tools "${1}@${3}" | |||
There was a problem hiding this comment.
I agree, probably we probably copied the command from there
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
What this PR does / why we need it: Updates
kpromoto the latest release so we can take advantage of 1) filtering by promotion by image to exclude CAPD images and 2) sorting by tag instead of by digest.https://github.com/kubernetes-sigs/promo-tools/releases/tag/v3.4.1
Test PR to promote fake v0.99.99 tag from this branch: https://github.com/kubernetes/k8s.io/pull/3683/files
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #