Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Makefile: re-enable hack/tools on make help #6441

Merged

Conversation

chrischdi
Copy link
Member

@chrischdi chrischdi commented Apr 25, 2022

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

fixes #6444

What else to add

Before:

$ make
...
  clean-release-git                              Restores the git files usually modified during a release
  clean-generated-conversions                    Remove files generated by conversion-gen from the mentioned dirs. Example SRC_DIRS="./api/v1alpha4"

hack/tools:

After:

$ make
...
  clean-release-git                              Restores the git files usually modified during a release
  clean-generated-conversions                    Remove files generated by conversion-gen from the mentioned dirs. Example SRC_DIRS="./api/v1alpha4"

hack/tools:
  controller-gen                                 Build a local copy of controller-gen.
  conversion-gen                                 Build a local copy of conversion-gen.
  conversion-verifier                            Build a local copy of conversion-verifier.
  gotestsum                                      Build a local copy of gotestsum.
  go-apidiff                                     Build a local copy of go-apidiff
  envsubst                                       Build a local copy of envsubst.
  kustomize                                      Build a local copy of kustomize.
  setup-envtest                                  Build a local copy of setup-envtest.
  kpromo                                         Build a local copy of kpromo
  tilt-prepare                                   Build a local copy of tilt-prepare.
  golangci-lint                                  Build a local copy of golangci-lint

* Fixes regression for make help introduced in kubernetes-sigs#5741

Signed-off-by: Christian Schlotter <[email protected]>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 25, 2022
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 25, 2022
@sbueringer
Copy link
Member

Thank you!

Verified and works

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 26, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 26, 2022
@k8s-ci-robot k8s-ci-robot merged commit ebc0869 into kubernetes-sigs:main Apr 26, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.2 milestone Apr 26, 2022
@chrischdi chrischdi deleted the pr-makefile-fix-tools-help branch June 30, 2022 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make help does not output hack/tools targets anymore
3 participants