Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 clusterctl: support disable version check #6439

Merged

Conversation

ykakarap
Copy link
Contributor

What this PR does / why we need it:

This PR adds support to disable clusterctl from checking for updates. This is useful when clusterctl is used in a air-gapped environments.

Usage: To disable the version checking add DISABLE_VERSIONCHECK: "true" to clusterctl.yaml or set an environment variable DISABLE_VERSIONCHECK="true".

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #6381

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 25, 2022
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 25, 2022
@ykakarap ykakarap force-pushed the clusterctl_disable-versioncheck branch from 3680f63 to cbfe132 Compare April 25, 2022 18:18
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 25, 2022
@ykakarap ykakarap force-pushed the clusterctl_disable-versioncheck branch from cbfe132 to d39fc20 Compare April 25, 2022 21:42
@chrischdi
Copy link
Member

/retitle 🌱 clusterctl: support disable version check

@k8s-ci-robot k8s-ci-robot changed the title 🌱 clusterct: support disable version check 🌱 clusterctl: support disable version check Apr 26, 2022
@sbueringer
Copy link
Member

@ykakarap Looks like this is an alternative to: #6382
Am I correct to assume that we will continue on #6439?

@ykakarap
Copy link
Contributor Author

@ykakarap Looks like this is an alternative to: #6382 Am I correct to assume that we will continue on #6439?

Correct.

@ykakarap ykakarap force-pushed the clusterctl_disable-versioncheck branch from d39fc20 to d3005a5 Compare April 27, 2022 02:37
@ykakarap
Copy link
Contributor Author

/retest

@ykakarap ykakarap force-pushed the clusterctl_disable-versioncheck branch from d3005a5 to ec23ca9 Compare April 27, 2022 18:22
@sbueringer
Copy link
Member

Thx!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 27, 2022
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor Author

@ykakarap ykakarap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign @fabriziopandini for approval.

@sbueringer
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2022
@k8s-ci-robot k8s-ci-robot merged commit 6a8f6b3 into kubernetes-sigs:main May 10, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.2 milestone May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to skip version check for Airgapped environments
5 participants