🌱 fix linting

[apricote]

What this PR does / why we need it:

Fix linting issues that are currently causing test failures in unrelated PRs. Issues were introduced by #6395, but I don't understand why they did not fail the checks back then.

[schrej]

/lgtm

[stmcginnis]

/lgtm

Thanks!

[jackfrancis]

Thank you @apricote!

[enxebre]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [enxebre]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sbueringer]

@apricote @CecileRobertMichon The issue wasn't caught in #6395 because the golangci-lint action was not run on the final commit of the PR. This was probably caused by the issue that we have to manually allow checks to run after each commit on PRs of new contributors.

[CecileRobertMichon]

@sbueringer this is because the github action (and same thing with other actions we run) is not marked as required on the main branch by branch protection rules in https://github.com/kubernetes-sigs/cluster-api/settings/branch_protection_rules

Do we want to mark this and other actions (if so which ones?) as required to make sure PRs can't merge without the action passing?

[sbueringer]

I would suggest:

But I think the important ones are the linter actions if you prefer to not add the other ones

[CecileRobertMichon]

@sbueringer I made the first 4 required but PR Desc and PR Type don't seem to show up as their own status. Theoretically this should prevent tide from merging but looks like there might be a bug preventing this behavior from working as expected according to kubernetes/test-infra#24921.

kubernetes/test-infra#25210 should also help with this so we can run all checks when "/ok-to-test" is commented on the PR for a new contributor.

[CecileRobertMichon]

I also found kubernetes/test-infra#22630 which seems to be doing what we want but the follow-up PRs suggest it didn't fully work... @cpanato @dims any insight on how we can make our lint GH Action required for tide merge in the CAPI repo? We want to make sure tide doesn't merge the PR before the action even runs when the contributor is new and the action needs manual approval before it can run.

[cpanato]

I also found kubernetes/test-infra#22630 which seems to be doing what we want but the follow-up PRs suggest it didn't fully work... @cpanato @dims any insight on how we can make our lint GH Action required for tide merge in the CAPI repo? We want to make sure tide doesn't merge the PR before the action even runs when the contributor is new and the action needs manual approval before it can run.

afaik you just need to make that check required in the repository and then prow will merge if all required checks are passing