Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 update cert-manager to v1.7.2 #6420

Merged
merged 1 commit into from
Apr 21, 2022
Merged

🌱 update cert-manager to v1.7.2 #6420

merged 1 commit into from
Apr 21, 2022

Conversation

ykakarap
Copy link
Contributor

What this PR does / why we need it:

This PR bumps the default version of cert-manager used to v1.7.2 from v1.5.3.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #6055

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 15, 2022
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 15, 2022
@ykakarap
Copy link
Contributor Author

/test ?

@k8s-ci-robot
Copy link
Contributor

@ykakarap: The following commands are available to trigger required jobs:

  • /test pull-cluster-api-build-main
  • /test pull-cluster-api-e2e-main
  • /test pull-cluster-api-test-main
  • /test pull-cluster-api-test-mink8s-main
  • /test pull-cluster-api-verify-main

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-apidiff-main
  • /test pull-cluster-api-e2e-full-main
  • /test pull-cluster-api-e2e-informing-ipv6-main
  • /test pull-cluster-api-e2e-informing-main
  • /test pull-cluster-api-e2e-workload-upgrade-1-23-latest-main

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-apidiff-main
  • pull-cluster-api-build-main
  • pull-cluster-api-e2e-informing-ipv6-main
  • pull-cluster-api-e2e-informing-main
  • pull-cluster-api-e2e-main
  • pull-cluster-api-test-main
  • pull-cluster-api-test-mink8s-main
  • pull-cluster-api-verify-main

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ykakarap
Copy link
Contributor Author

/test pull-cluster-api-e2e-full-main

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 15, 2022 •
edited
Loading

@ykakarap: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-apidiff-main b54aea0 link false /test pull-cluster-api-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ykakarap
Copy link
Contributor Author

/test pull-cluster-api-e2e-full-main

killianmuldoon
killianmuldoon approved these changes Apr 16, 2022
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 16, 2022
fabriziopandini
fabriziopandini reviewed Apr 16, 2022
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

/hold
For a PSA at the net office hours, otherwise lgtm
@ykakarap do you mind adding a point in agenda for this?

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 16, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 16, 2022
@dntosas
Copy link
Contributor

dntosas commented Apr 17, 2022

btw, there is also cert-manager v1.8.0 now available --> https://github.com/cert-manager/cert-manager/releases/tag/v1.8.0

@fabriziopandini
Copy link
Member

@dntosas I would prefer to bump to latest in 1.7, backport, and then jump on the new 1.8 and give it as many test cycles as we can

@dntosas
Copy link
Contributor

dntosas commented Apr 19, 2022

Yes, totally agree ^^ i just posted it for awareness

@ykakarap
Copy link
Contributor Author

/lgtm /approve

/hold For a PSA at the net office hours, otherwise lgtm @ykakarap do you mind adding a point in agenda for this?

Done. Added an item to the April 20th meeting.

@fabriziopandini
Copy link
Member

As per 20th Apr meeting
Ok to bump the cert-manager version on main + backport on v1.1
A broader discussion is required on cert-manager updates given the 4-month support window https://cert-manager.io/docs/installation/supported-releases/#support-policy; I will open a issue for this

@fabriziopandini
Copy link
Member

/hold cancel
/cherry-pick release-1.1

@k8s-infra-cherrypick-robot
Copy link

@fabriziopandini: once the present PR merges, I will cherry-pick it on top of release-1.1 in a new PR and assign it to you.

In response to this:

/hold cancel
/cherry-pick release-1.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 21, 2022
@k8s-ci-robot k8s-ci-robot merged commit c5b5f25 into kubernetes-sigs:main Apr 21, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.2 milestone Apr 21, 2022
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Apr 21, 2022
Merged
@k8s-infra-cherrypick-robot
Copy link

@fabriziopandini: new pull request created: #6432

In response to this:

/hold cancel
/cherry-pick release-1.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@killianmuldoon killianmuldoon killianmuldoon approved these changes

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

Assignees

@fabriziopandini fabriziopandini

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.

bump default cert-manager version to v1.7.0
6 participants
@ykakarap @k8s-ci-robot @dntosas @fabriziopandini @k8s-infra-cherrypick-robot @killianmuldoon