Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [etcd] Bump go package to v3.5.3 #6414

Merged

Conversation

dntosas
Copy link
Contributor

@dntosas dntosas commented Apr 14, 2022

What this PR does / why we need it:
Upgrading etcd golang libraries to the version that mitigates a critical
issue which leds to data corruption --> https://github.com/ahrtr/etcd-issues/tree/master/issues/13766

Signed-off-by: dntosas [email protected]

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 14, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @dntosas. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 14, 2022
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall - but could you remove the irrelevant changes to the clusterclass doc?

@killianmuldoon
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 14, 2022
@dntosas dntosas force-pushed the feat/bump-etcd-version-3.5.3 branch from 5adc0a2 to 2ddf308 Compare April 14, 2022 14:57
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 14, 2022
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the CI issues should be cleaned up if you run make generate-modules

That pretty much just runs go mod tidy for each of the modules in the repo (hack and test each having their own go.mod)

Upgrading etcd golang libraries to the version that mitigates a critical
issue which leds to data corruption --> https://github.com/ahrtr/etcd-issues/tree/master/issues/13766

Signed-off-by: dntosas <[email protected]>
@dntosas dntosas force-pushed the feat/bump-etcd-version-3.5.3 branch from 2ddf308 to 03417f4 Compare April 14, 2022 17:35
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 14, 2022
@dntosas
Copy link
Contributor Author

dntosas commented Apr 14, 2022

thnx for the tip @killianmuldoon :) i think we are good now

Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 15, 2022
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2022
@k8s-ci-robot k8s-ci-robot merged commit 907debc into kubernetes-sigs:main Apr 15, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.2 milestone Apr 15, 2022
@sbueringer
Copy link
Member

sbueringer commented Apr 26, 2022

Just to note: this PR is fine but I think we don't have to upgrade the libraries to resolve the issue as the issue is in the etcd server.

I couldn't find the place where I read it, the best reference that I could find was:

There are no breaking changes in API, meaning it’s safe to let v3.5 clients (e.g. the latest Kubernetes releases) talk to v3.4 servers.
https://groups.google.com/a/kubernetes.io/g/dev/c/B7gJs88XtQc

(I think it's worth mentioning because otherwise we would need more cherry-picking)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants