-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 [etcd] Bump go package to v3.5.3 #6414
🐛 [etcd] Bump go package to v3.5.3 #6414
Conversation
Hi @dntosas. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall - but could you remove the irrelevant changes to the clusterclass doc?
/ok-to-test |
5adc0a2
to
2ddf308
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the CI issues should be cleaned up if you run make generate-modules
That pretty much just runs go mod tidy
for each of the modules in the repo (hack and test each having their own go.mod)
Upgrading etcd golang libraries to the version that mitigates a critical issue which leds to data corruption --> https://github.com/ahrtr/etcd-issues/tree/master/issues/13766 Signed-off-by: dntosas <[email protected]>
2ddf308
to
03417f4
Compare
thnx for the tip @killianmuldoon :) i think we are good now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Just to note: this PR is fine but I think we don't have to upgrade the libraries to resolve the issue as the issue is in the etcd server. I couldn't find the place where I read it, the best reference that I could find was:
(I think it's worth mentioning because otherwise we would need more cherry-picking) |
What this PR does / why we need it:
Upgrading etcd golang libraries to the version that mitigates a critical
issue which leds to data corruption --> https://github.com/ahrtr/etcd-issues/tree/master/issues/13766
Signed-off-by: dntosas [email protected]
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #