-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ RuntimeSDK: Add extension config controller skeleton #6411
✨ RuntimeSDK: Add extension config controller skeleton #6411
Conversation
/retest |
@ykakarap Based on comments on the other PR I assume you have access to Kilian's repo. Could you maybe rebase this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Pending rebase (and dropping the first 5 commits) + fixing the nits, lgtm from my side
Signed-off-by: killianmuldoon <[email protected]>
378ffda
to
e899618
Compare
@sbueringer I rebased and addressed all the comments. I dont have permissions to resolve conversations, can you please mark them as resolved if you are happy with them? |
/retitle RuntimeSDK: Add extension config controller skeleton /lgtm /assign @fabriziopandini @killianmuldoon @ykakarap Thank you very much! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR adds a skeleton controller to handle the ExtensionConfig object added in #6383. This controller will eventually be used to handle status updates to the ExtensionConfig CRD.
Note: This PR includes #6383 and should not be merged until that PR is merged. This PR will require a rebase before merging.
Part of: #6330