Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ RuntimeSDK: Add extension config controller skeleton #6411

Conversation

killianmuldoon
Copy link
Contributor

@killianmuldoon killianmuldoon commented Apr 12, 2022

This PR adds a skeleton controller to handle the ExtensionConfig object added in #6383. This controller will eventually be used to handle status updates to the ExtensionConfig CRD.

Note: This PR includes #6383 and should not be merged until that PR is merged. This PR will require a rebase before merging.

Part of: #6330

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 12, 2022
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 12, 2022
@killianmuldoon killianmuldoon changed the title Runtime sdk/add extension config controller ✨ [WIP] Runtime sdk/add extension config controller Apr 12, 2022
@killianmuldoon
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 27, 2022
@sbueringer
Copy link
Member

@ykakarap Based on comments on the other PR I assume you have access to Kilian's repo. Could you maybe rebase this PR?

@sbueringer sbueringer mentioned this pull request Apr 27, 2022
30 tasks
Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Pending rebase (and dropping the first 5 commits) + fixing the nits, lgtm from my side

exp/runtime/controllers/alias.go Outdated Show resolved Hide resolved
exp/runtime/controllers/alias.go Show resolved Hide resolved
@ykakarap ykakarap force-pushed the runtimeSDK/add-extensionConfigController branch from 378ffda to e899618 Compare April 27, 2022 16:55
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 27, 2022
@ykakarap
Copy link
Contributor

@sbueringer I rebased and addressed all the comments. I dont have permissions to resolve conversations, can you please mark them as resolved if you are happy with them?

@sbueringer
Copy link
Member

sbueringer commented Apr 27, 2022

/retitle RuntimeSDK: Add extension config controller skeleton

/lgtm

/assign @fabriziopandini
When you've got some time. I think this is ready to go.

@killianmuldoon @ykakarap Thank you very much!

@k8s-ci-robot k8s-ci-robot changed the title ✨ [WIP] Runtime sdk/add extension config controller RuntimeSDK: Add extension config controller skeleton Apr 27, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 27, 2022
@sbueringer sbueringer changed the title RuntimeSDK: Add extension config controller skeleton ✨ RuntimeSDK: Add extension config controller skeleton Apr 27, 2022
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2022
@k8s-ci-robot k8s-ci-robot merged commit 2982a32 into kubernetes-sigs:main Apr 29, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.2 milestone Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants