Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vincepri to project's maintainers #640

Closed
wants to merge 1 commit into from

Conversation

vincepri
Copy link
Member

What this PR does / why we need it:
Add myself to the maintainer list so I can review and approve PRs.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 14, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vincepri
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: karan

If they are not already assigned, you can assign the PR to them by writing /assign @karan in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roberthbailey
Copy link
Contributor

We didn't bring this up at the meeting last week, but we should establish some sort of pseudo-formal procedure for promoting folks to be maintainers. Let me know if you have any good ideas for what data we can use to be as objective as possible (something along the lines of number of lgtms on PRs that subsequently merged seems reasonable).

/cc @justinsb in case you have ideas or suggestions from your experience promoting folks to be maintainers of kops.

@roberthbailey
Copy link
Contributor

Closing in favor of #670.

@vincepri vincepri deleted the patch-1 branch July 26, 2019 18:21
jayunit100 pushed a commit to jayunit100/cluster-api that referenced this pull request Jan 31, 2020
Update CSI default images to v1.0.1 on gcr.io
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants