Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 update talos/sidero references #6328

Merged
merged 1 commit into from
Mar 28, 2022

Conversation

rsmitty
Copy link
Contributor

@rsmitty rsmitty commented Mar 23, 2022

What this PR does / why we need it:

Talos Systems is now Sidero Labs and we just renamed our github org.
This PR updates all of the references to make sure they align with the
new org name. Saw an issue where clusterctl couldn't follow the
redirects to the yaml assets, which appears to also occur when manually
curling (assuming a github bug).

Signed-off-by: Spencer Smith [email protected]

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 23, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 23, 2022
@sbueringer
Copy link
Member

@rsmitty Thx for the PR.

Lgtm from my side when the unit test is fixed (looks like some issue with the diff)

@killianmuldoon
Copy link
Contributor

/lgtm

(pending unit test)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 24, 2022
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 24, 2022
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 24, 2022
@rsmitty rsmitty force-pushed the master branch 5 times, most recently from 117ad6d to e9b7095 Compare March 24, 2022 13:58
Talos Systems is now Sidero Labs and we just renamed our github org.
This PR updates all of the references to make sure they align with the
new org name. Saw an issue where clusterctl couldn't follow the
redirects to the yaml assets, which appears to also occur when manually
curling (assuming a github bug).

Signed-off-by: Spencer Smith <[email protected]>
@rsmitty
Copy link
Contributor Author

rsmitty commented Mar 24, 2022

okay @sbueringer and @killianmuldoon, I finally found the magic spacing for getting the tests to pass :D

should be good to go now. thx!

@sbueringer
Copy link
Member

sbueringer commented Mar 24, 2022

Perfect, thx! :)

/lgtm

The change looks to me like we should backport it to v1.1. @rsmitty WDYT?

@rsmitty
Copy link
Contributor Author

rsmitty commented Mar 24, 2022

yep, will do after this is merged.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 24, 2022
@fabriziopandini
Copy link
Member

/lgtm
/approve
/cherry-pick v1.1

@k8s-infra-cherrypick-robot

@fabriziopandini: once the present PR merges, I will cherry-pick it on top of v1.1 in a new PR and assign it to you.

In response to this:

/lgtm
/approve
/cherry-pick v1.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 28, 2022
@k8s-ci-robot k8s-ci-robot merged commit 514e2aa into kubernetes-sigs:main Mar 28, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.2 milestone Mar 28, 2022
@k8s-infra-cherrypick-robot

@fabriziopandini: cannot checkout v1.1: error checking out v1.1: exit status 1. output: error: pathspec 'v1.1' did not match any file(s) known to git

In response to this:

/lgtm
/approve
/cherry-pick v1.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbueringer
Copy link
Member

/cherry-pick release-1.1

@rsmitty you don't have to do it manually :)

@k8s-infra-cherrypick-robot

@sbueringer: new pull request created: #6343

In response to this:

/cherry-pick release-1.1

@rsmitty you don't have to do it manually :)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants