-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 update talos/sidero references #6328
Conversation
@rsmitty Thx for the PR. Lgtm from my side when the unit test is fixed (looks like some issue with the diff) |
/lgtm (pending unit test) |
117ad6d
to
e9b7095
Compare
Talos Systems is now Sidero Labs and we just renamed our github org. This PR updates all of the references to make sure they align with the new org name. Saw an issue where clusterctl couldn't follow the redirects to the yaml assets, which appears to also occur when manually curling (assuming a github bug). Signed-off-by: Spencer Smith <[email protected]>
okay @sbueringer and @killianmuldoon, I finally found the magic spacing for getting the tests to pass :D should be good to go now. thx! |
Perfect, thx! :) /lgtm The change looks to me like we should backport it to v1.1. @rsmitty WDYT? |
yep, will do after this is merged. |
/lgtm |
@fabriziopandini: once the present PR merges, I will cherry-pick it on top of v1.1 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@fabriziopandini: cannot checkout In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-1.1 @rsmitty you don't have to do it manually :) |
@sbueringer: new pull request created: #6343 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
Talos Systems is now Sidero Labs and we just renamed our github org.
This PR updates all of the references to make sure they align with the
new org name. Saw an issue where clusterctl couldn't follow the
redirects to the yaml assets, which appears to also occur when manually
curling (assuming a github bug).
Signed-off-by: Spencer Smith [email protected]