Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Topology Mutation: use API types for inline patching #6289

Merged
merged 1 commit into from
Jun 9, 2022
Merged

✨ Topology Mutation: use API types for inline patching #6289

merged 1 commit into from
Jun 9, 2022

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented Mar 10, 2022 •
edited
Loading

Refactors inline patching to use the same API types as external patches

Part of #6545

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 10, 2022
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 10, 2022
killianmuldoon
killianmuldoon reviewed May 9, 2022
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/area runtime-sdk

@k8s-ci-robot k8s-ci-robot added the area/runtime-sdk Issues or PRs related to Runtime SDK label May 9, 2022
@sbueringer sbueringer force-pushed the pr-topology-mutation branch from 91fb098 to af5337f Compare May 13, 2022 16:53
@sbueringer sbueringer force-pushed the pr-topology-mutation branch from af5337f to 5bcb514 Compare May 30, 2022 11:57
@sbueringer sbueringer changed the title [WIP][DONT_REVIEW] External Patching Experiments [WIP] ✨ Topology Mutation: use API types for inline patching May 30, 2022
@sbueringer sbueringer mentioned this pull request May 30, 2022
Closed
5 tasks
@sbueringer sbueringer force-pushed the pr-topology-mutation branch 2 times, most recently from ee63e08 to b062d5b Compare May 30, 2022 16:11
@sbueringer sbueringer changed the title [WIP] ✨ Topology Mutation: use API types for inline patching ✨ Topology Mutation: use API types for inline patching May 30, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 30, 2022
@sbueringer
Copy link
Member Author

sbueringer commented May 30, 2022 •
edited
Loading

This PR is now ready for review, but
/hold
until #6514 is merged (this PR currently contains #6514)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 30, 2022
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-full-main
/test pull-cluster-api-e2e-workload-upgrade-1-24-latest-main

@kubernetes-sigs kubernetes-sigs deleted a comment from k8s-ci-robot May 30, 2022
@sbueringer sbueringer force-pushed the pr-topology-mutation branch from b062d5b to f28baa2 Compare May 31, 2022 10:36
@sbueringer
Copy link
Member Author

underlying PR merged + this PR rebased
/hold cancel

/test pull-cluster-api-e2e-full-main
/test pull-cluster-api-e2e-workload-upgrade-1-24-latest-main

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 31, 2022
@sbueringer sbueringer force-pushed the pr-topology-mutation branch 2 times, most recently from d2b8701 to 3846d3e Compare June 1, 2022 19:24
fabriziopandini
fabriziopandini reviewed Jun 6, 2022
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is great to see topology mutation hooks to fit in the initial patch implementation, great work!
two nits, not blocking.
I give some time for the others to review, otherwise lgtm

internal/controllers/topology/cluster/patches/inline/json_patch_generator.go Show resolved Hide resolved
internal/controllers/topology/cluster/patches/template.go Show resolved Hide resolved
@fabriziopandini
Copy link
Member

fabriziopandini commented Jun 8, 2022 •
edited
Loading

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 8, 2022
@fabriziopandini
Copy link
Member

fabriziopandini commented Jun 8, 2022 •
edited
Loading

/approve
/hold
to give folks some more time for review, otherwise I will merge by EOD so we can have some test cycles before the release

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 8, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 8, 2022
@fabriziopandini
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 8, 2022
@sbueringer
Copy link
Member Author

Will rebase + ping for lgtm tomorrow

@sbueringer sbueringer force-pushed the pr-topology-mutation branch from 3846d3e to 77ec3b1 Compare June 9, 2022 04:01
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 9, 2022
@sbueringer
Copy link
Member Author

Rebase done, needs-lgtm again :)

@sbueringer sbueringer force-pushed the pr-topology-mutation branch from 77ec3b1 to 402698e Compare June 9, 2022 04:09
@fabriziopandini
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 9, 2022
@k8s-ci-robot k8s-ci-robot merged commit 0bf6351 into kubernetes-sigs:main Jun 9, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.2 milestone Jun 9, 2022
@sbueringer sbueringer mentioned this pull request Jun 9, 2022
Closed
30 tasks
@sbueringer sbueringer deleted the pr-topology-mutation branch June 9, 2022 10:35
This was referenced Jul 18, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killianmuldoon killianmuldoon killianmuldoon left review comments

@fabriziopandini fabriziopandini fabriziopandini left review comments

@enxebre enxebre Awaiting requested review from enxebre

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

Assignees

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/runtime-sdk Issues or PRs related to Runtime SDK cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.
4 participants
@sbueringer @fabriziopandini @k8s-ci-robot @killianmuldoon