-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 add ykakarap to clusterctl reviewers #6275
🌱 add ykakarap to clusterctl reviewers #6275
Conversation
Nice!! P.S. I think you need a longer PR description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
/lgtm
/hold
Is that blocking? |
I'm not 100% sure, but I think yes. Tide shows it here: https://prow.k8s.io/pr?query=is%3Apr+repo%3Akubernetes-sigs%2Fcluster-api+author%3Aykakarap+head%3Aadd-ykakarap-clusterctl-reviewer But you can just edit the description and add either some parts of the template or some random things that you always wanted to say there :) (threshold is 80 characters after strings.TrimSpace) |
Thanks for stepping up! and thank you as well for all the great work so far! |
+1 🚀 |
+1 |
/hold cancel |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
PR to add myself as a reviewer under clusterctl reviewer alias 🙂