Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 add ykakarap to clusterctl reviewers #6275

Merged

Conversation

ykakarap
Copy link
Contributor

@ykakarap ykakarap commented Mar 8, 2022

What this PR does / why we need it:
PR to add myself as a reviewer under clusterctl reviewer alias 🙂

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 8, 2022
@sbueringer
Copy link
Member

Nice!!
/lgtm

P.S. I think you need a longer PR description.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 8, 2022
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

/lgtm
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 8, 2022
@ykakarap
Copy link
Contributor Author

ykakarap commented Mar 9, 2022

P.S. I think you need a longer PR description.

Is that blocking?

@sbueringer
Copy link
Member

P.S. I think you need a longer PR description.

Is that blocking?

I'm not 100% sure, but I think yes. Tide shows it here: https://prow.k8s.io/pr?query=is%3Apr+repo%3Akubernetes-sigs%2Fcluster-api+author%3Aykakarap+head%3Aadd-ykakarap-clusterctl-reviewer
Also GitHub actions in general (e.g. linkchecker) block merges.

But you can just edit the description and add either some parts of the template or some random things that you always wanted to say there :) (threshold is 80 characters after strings.TrimSpace)

@fabriziopandini
Copy link
Member

Thanks for stepping up! and thank you as well for all the great work so far!
/lgtm

@elmiko
Copy link
Contributor

elmiko commented Mar 9, 2022

+1 🚀

@stmcginnis
Copy link
Contributor

+1
/lgtm

@fabriziopandini
Copy link
Member

/hold cancel
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 17, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 17, 2022
@k8s-ci-robot k8s-ci-robot merged commit f008f26 into kubernetes-sigs:main Mar 17, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.2 milestone Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants