✨ clusterctl: allow Namespace objects in topology plan input

[apricote]

What this PR does / why we need it:

Adds support for Namespace objects in clusterctl alpha topology plan input. Previously it would have counted as another unique namespace, but now we just add the metadata.name of the Namespace into the set of unique namespaces.

Which issue(s) this PR fixes:
Fixes #6236

[k8s-ci-robot]

Hi @apricote. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sbueringer]

/ok-to-test

[fabriziopandini]

/lgtm
@ykakarap PTAL

[sbueringer]

/lgtm

[ykakarap]

You will need to adjust the logic in setMissingNamespaces function to skip Namespace objects.

[ykakarap]

/hold

[apricote]

Added handling in setMissingNamespaces and adopted the check from

cluster-api/cmd/clusterctl/client/cluster/components.go

Line 159 in 0195739

isNamespace := obj.GroupVersionKind().Kind == namespaceKind

to be consistent within the module.

[sbueringer]

/lgtm

[ykakarap]

/lgtm

[sbueringer]

You will need to adjust the logic in setMissingNamespaces function to skip Namespace objects.

Nice catch!

[ykakarap]

/hold cancel

[fabriziopandini]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [fabriziopandini]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[fabriziopandini]

/cherry-pick release-1.1

[k8s-infra-cherrypick-robot]

@fabriziopandini: once the present PR merges, I will cherry-pick it on top of release-1.1 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-infra-cherrypick-robot]

@fabriziopandini: new pull request created: #6265

In response to this:

/cherry-pick release-1.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.