-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 util/version: Add option to compare without prereleases #6252
🐛 util/version: Add option to compare without prereleases #6252
Conversation
Welcome @SubhasmitaSw! |
Hi @SubhasmitaSw. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
81db278
to
6123e0d
Compare
5502f9c
to
847c0e7
Compare
/retest |
/retitle 🐛 util/version: Add option to compare without prereleases |
@SubhasmitaSw Thank you!! (We're using prow in merge mode to be able to generate release notes, so the commits are preserved after merge) |
26e9970
to
969e6b1
Compare
Thank you @sbueringer for helping through. |
Sure, no problem :) /lgtm /assign @fabriziopandini for approval |
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/lgtm |
/approve cancel |
Hm strange not sure how I missed that, maybe it didn't run before. @SubhasmitaSw Can you please add a godoc comment for the |
sure, and apology for being late. |
f9e7d27
to
dca60b8
Compare
No worries. Good first issues are intentional not time-critical (most of our other issues are also not time-critical) /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
All green |
What this PR does / why we need it:
/kind bug
Rif #4938
cc @sbueringer