Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 util/version: Add option to compare without prereleases #6252

Merged
merged 1 commit into from
Mar 28, 2022

Conversation

SubhasmitaSw
Copy link
Contributor

@SubhasmitaSw SubhasmitaSw commented Mar 3, 2022

What this PR does / why we need it:
/kind bug

Rif #4938

cc @sbueringer

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 3, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @SubhasmitaSw!

It looks like this is your first PR to kubernetes-sigs/cluster-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @SubhasmitaSw. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 3, 2022
@SubhasmitaSw SubhasmitaSw changed the title [WIP] 🐛 reconsider k8s version comparison 🐛 [WIP] reconsider k8s version comparison Mar 3, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 3, 2022
util/version/version.go Outdated Show resolved Hide resolved
util/version/version.go Outdated Show resolved Hide resolved
@sbueringer
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 7, 2022
util/version/version.go Outdated Show resolved Hide resolved
@sbueringer
Copy link
Member

/retest

@sbueringer
Copy link
Member

/retitle 🐛 util/version: Add option to compare without prereleases

@k8s-ci-robot k8s-ci-robot changed the title 🐛 [WIP] reconsider k8s version comparison 🐛 util/version: Add option to compare without prereleases Mar 15, 2022
util/version/version.go Outdated Show resolved Hide resolved
@sbueringer
Copy link
Member

@SubhasmitaSw Thank you!!
Please squash the commits, then we should be good to go/merge :)

(We're using prow in merge mode to be able to generate release notes, so the commits are preserved after merge)

@SubhasmitaSw
Copy link
Contributor Author

@SubhasmitaSw Thank you!! Please squash the commits, then we should be good to go/merge :)

(We're using prow in merge mode to be able to generate release notes, so the commits are preserved after merge)

Thank you @sbueringer for helping through.

@sbueringer
Copy link
Member

Sure, no problem :)

/lgtm

/assign @fabriziopandini for approval

@k8s-ci-robot

This comment was marked as resolved.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 15, 2022
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@fabriziopandini
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2022
@fabriziopandini
Copy link
Member

/approve cancel
it seems there are lint errrors

@k8s-ci-robot k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2022
@sbueringer
Copy link
Member

sbueringer commented Mar 18, 2022

Hm strange not sure how I missed that, maybe it didn't run before. @SubhasmitaSw Can you please add a godoc comment for the WithoutPreReleases func?

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 26, 2022
@SubhasmitaSw
Copy link
Contributor Author

Hm strange not sure how I missed that, maybe it didn't run before. @SubhasmitaSw Can you please add a godoc comment for the WithoutPreReleases func?

sure, and apology for being late.

@sbueringer
Copy link
Member

Hm strange not sure how I missed that, maybe it didn't run before. @SubhasmitaSw Can you please add a godoc comment for the WithoutPreReleases func?

sure, and apology for being late.

No worries. Good first issues are intentional not time-critical (most of our other issues are also not time-critical)

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 28, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 28, 2022
@sbueringer
Copy link
Member

/hold
for golangci-lint results. The workflows were not approved to run before.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 28, 2022
@sbueringer
Copy link
Member

All green
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 28, 2022
@k8s-ci-robot k8s-ci-robot merged commit e30dee8 into kubernetes-sigs:main Mar 28, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.2 milestone Mar 28, 2022
@SubhasmitaSw SubhasmitaSw deleted the k8s_ver_compare branch March 28, 2022 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants