-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 fix file name of clusterclass proposal #6234
📖 fix file name of clusterclass proposal #6234
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Q: Do we have any links to the proposal that we should fix? (I'm aware we can't fix them all, but maybe let's check with grep.app if there are some best-effort fixes we should make) EDIT: looks like only in our repo, but we just fix them: https://grep.app/search?q=202105256-cluster-class-and-managed-topologies.md (link checker can't find those broken links because they will only break after merge) |
dc5e5ba
to
78dd064
Compare
GitHub Code Search found two more that aren't just forks. |
Broken links look fine to me -they're just a result of updating the links here. /lgtm |
I think we are referencing this from the Kubernetes blog... |
The Introducing ClusterClass and Managed Topologies in Cluster API blog post doesn't mention it. |
But it does link https://cluster-api.sigs.k8s.io/tasks/experimental-features/cluster-classes.html (which is dead). I'll add a cluster-class reference page with links to that address in main. I guess we might have to backport to 1.1 to get it in the latest version of the book though, right @sbueringer? |
According to GitHub code search there is no reference to |
Yes |
@killianmuldoon I'm not sure if we should add another page so that the old link still works. We already have that page: https://cluster-api.sigs.k8s.io/tasks/experimental-features/cluster-class/index.html I would prefer fixing the link in the Kubernetes blog post Independent of that. I think we can merge the current PR |
I was thinking of moving that index page to the location of the old cluster-classes.md which would minimally fix the issue and only slightly disturb the structure. |
Sounds good! Probably it's even more correct as the other pages on that level are also like this and not inside of sub-paths. |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work for searching/fixing for broken links
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I merged it manually, given that it would have been impossible because of the linkchecker otherwise. |
The date at the beginning contains an extra digit, which breaks sorting when adding newer proposals.
Since the PR validation complains that this description is a little short, I'll add this line to hopefully satisfy it 😄