Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 apidiff: deduplicate apidiff logic #6180

Merged

Conversation

sbueringer
Copy link
Member

Signed-off-by: Stefan Büringer [email protected]

What this PR does / why we need it:
This PR deduplicates the apidiff "logic". We should use our makefile targets in CI when easily possible.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 21, 2022
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 21, 2022
@sbueringer
Copy link
Member Author

cc @sonasingh46 @geetikabatra

Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 21, 2022
@geetikabatra
Copy link

Thanks @sbueringer
/lgtm

@k8s-ci-robot
Copy link
Contributor

@geetikabatra: changing LGTM is restricted to collaborators

In response to this:

Thanks @sbueringer
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbueringer
Copy link
Member Author

/retest
(hopefully) unrelated flake

@sbueringer sbueringer force-pushed the pr-deduplicate-apidiff branch from 964407d to 3c01f4f Compare February 21, 2022 16:50
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 21, 2022
@sbueringer sbueringer force-pushed the pr-deduplicate-apidiff branch from 3c01f4f to 3fee1d5 Compare February 21, 2022 16:52
@sbueringer
Copy link
Member Author

sbueringer commented Feb 21, 2022

Had to use ?= instead of := to make it overwritable

@killianmuldoon
Copy link
Contributor

Had to use ?= instead of := to make it overwritable

TIL 😄

@killianmuldoon
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 21, 2022
@fabriziopandini
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2022
@k8s-ci-robot k8s-ci-robot merged commit bb5bfd1 into kubernetes-sigs:main Feb 22, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.2 milestone Feb 22, 2022
@sbueringer sbueringer deleted the pr-deduplicate-apidiff branch February 22, 2022 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants