Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 Docs: Installing clusterctl on windows section added #6177

Merged
merged 1 commit into from
Mar 11, 2022
Merged

📖 Docs: Installing clusterctl on windows section added #6177

merged 1 commit into from
Mar 11, 2022

Conversation

VibhorChinda
Copy link
Contributor

@VibhorChinda VibhorChinda commented Feb 18, 2022 •
edited by fabriziopandini
Loading

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #6161

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 18, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @VibhorChinda!

It looks like this is your first PR to kubernetes-sigs/cluster-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @VibhorChinda. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 18, 2022
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 18, 2022
@VibhorChinda
Copy link
Contributor Author

@ykakarap have a look please :)

@VibhorChinda VibhorChinda changed the title Installing clusterctl on windows section added Docs: 📖Installing clusterctl on windows section added Feb 18, 2022
@VibhorChinda VibhorChinda changed the title Docs: 📖Installing clusterctl on windows section added 📖 Docs: Installing clusterctl on windows section added Feb 18, 2022
@palnabarun
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 18, 2022
killianmuldoon
killianmuldoon approved these changes Feb 18, 2022
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! Will hopefully make it easier for people to get up and running on Windows. Do we know if the rest of the guide works for windows? Kind etc.?

docs/book/src/user/quick-start.md Outdated Show resolved Hide resolved
docs/book/src/user/quick-start.md Outdated Show resolved Hide resolved
@VibhorChinda
Copy link
Contributor Author

Thanks for this PR! Will hopefully make it easier for people to get up and running on Windows. Do we know if the rest of the guide works for windows? Kind etc.?

Yes, I am new to this community and was trying to setup everything kind, docker, kubectl, clusterctl on windows following the quick start guide. Everything else works fine.

ykakarap
ykakarap suggested changes Feb 22, 2022
View reviewed changes
docs/book/src/user/quick-start.md Outdated Show resolved Hide resolved
docs/book/src/user/quick-start.md Outdated Show resolved Hide resolved
@VibhorChinda
Copy link
Contributor Author

VibhorChinda commented Feb 22, 2022 •
edited
Loading

@ykakarap can these links can be added ?
https://docs.oracle.com/en/database/oracle/machine-learning/oml4r/1.5.1/oread/creating-and-modifying-environment-variables-on-windows.html#GUID-DD6F9982-60D5-48F6-8270-A27EC53807D0 [Official Oracle docs]

https://www.computerhope.com/issues/ch000549.htm [More detailed link]

ykakarap
ykakarap reviewed Feb 23, 2022
View reviewed changes
Copy link
Contributor

@ykakarap ykakarap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VibhorChinda Lets not add any links for now. (kubectl install on windows does not either). Lets just keep it as is. We can comeback to adding links/example if we get feedback about it.

Please make sure to squash commits.

@VibhorChinda
Copy link
Contributor Author

@ykakarap have a look please :)

killianmuldoon
killianmuldoon approved these changes Mar 3, 2022
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tiniest of nits 😄
Otherwise:
/lgtm

docs/book/src/user/quick-start.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 3, 2022
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 3, 2022
@killianmuldoon
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 3, 2022
ykakarap
ykakarap reviewed Mar 5, 2022
View reviewed changes
Copy link
Contributor

@ykakarap ykakarap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last nit :)

otherwise LGTM.

Thank for the PR @VibhorChinda !!

docs/book/src/user/quick-start.md Outdated Show resolved Hide resolved
@VibhorChinda
Added how to install clusterctl section on Windows
312df2e 
Adding section to install clusterctl on windows

Added Installing Clusterctl Section in Windows

Installing clusterctl on windows section added

rectified casing

changed link

small typo fix

minor typo fix
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 6, 2022
ykakarap
ykakarap approved these changes Mar 7, 2022
View reviewed changes
Copy link
Contributor

@ykakarap ykakarap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 7, 2022
@killianmuldoon
Copy link
Contributor

/lgtm

@VibhorChinda VibhorChinda requested a review from stmcginnis March 8, 2022 13:41
@fabriziopandini
Copy link
Member

@VibhorChinda thanks for your first PR to Cluster API !
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2022
@fabriziopandini
Copy link
Member

/test pull-cluster-api-test-mink8s-main

@k8s-ci-robot k8s-ci-robot merged commit 5fea047 into kubernetes-sigs:main Mar 11, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.2 milestone Mar 11, 2022
@VibhorChinda VibhorChinda deleted the Vibhor branch March 16, 2022 16:32
@VibhorChinda VibhorChinda mentioned this pull request Nov 2, 2022
Closed
9 tasks
@VibhorChinda VibhorChinda mentioned this pull request May 24, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killianmuldoon killianmuldoon killianmuldoon approved these changes

@ykakarap ykakarap ykakarap approved these changes

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@stmcginnis stmcginnis Awaiting requested review from stmcginnis

Assignees

@fabriziopandini fabriziopandini

@ykakarap ykakarap

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.

windows section for Install clusterctl in quick start
7 participants
@VibhorChinda @k8s-ci-robot @palnabarun @killianmuldoon @fabriziopandini @stmcginnis @ykakarap