📖 book: document component-base/logs change in migration doc #6168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
size/XS
k8s-ci-robot
added
the
lgtm
sbueringer
commented
Feb 23, 2022
sbueringer
force-pushed
the
pr-doc-json-log-change
branch
from
b415e19 to
c34539e
Compare
k8s-ci-robot
removed
the
lgtm
| - To align with the upstream Kubernetes community CAPI now configures logging via `component-base/logs`. | ||
| This provides advantages like support for the JSON logging format (via `--logging-format=json`) and automatic | ||
| deprecation of klog flags aligned to the upstream Kubernetes deprecation period. For more details please see: | ||
| [#6072](https://github.com/kubernetes-sigs/cluster-api/pull/6072) and [#6190](https://github.com/kubernetes-sigs/cluster-api/pull/6190). |
There was a problem hiding this comment.
Instead of linking to PRs one built on top of the other can we add a diff snippet with all the changes to e.g. main.go?
There was a problem hiding this comment.
Updated. I added a diff with the most important changes. I still kept links to the PRs around for changes like go.mod, imports, ... . So folks can look those details up if needed.
Signed-off-by: Stefan Büringer [email protected]
sbueringer
force-pushed
the
pr-doc-json-log-change
branch
from
c34539e to
942f57c
Compare
k8s-ci-robot
added
size/M
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stefan Büringer [email protected]
What this PR does / why we need it:
Follow-up to: #6072
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #