Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 Updated version pattern matching in quick-start #6137

Merged
merged 1 commit into from
Feb 16, 2022
Merged

📖 Updated version pattern matching in quick-start #6137

merged 1 commit into from
Feb 16, 2022

Conversation

joekr
Copy link
Member

@joekr joekr commented Feb 15, 2022

What this PR does / why we need it:
The old 1.0.x wasn't matching the new version. Instead of making the
change now for each new minor release this will match all minor and
patch releases.

Related issue: #6136

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 15, 2022 •
edited
Loading

CLA Signed

The committers are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Feb 15, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @joekr!

It looks like this is your first PR to kubernetes-sigs/cluster-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 15, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @joekr. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 15, 2022
@sbueringer
Copy link
Member

@joekr Thank you very much!

/lgtm
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 15, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 15, 2022
fabriziopandini
fabriziopandini reviewed Feb 15, 2022
View reviewed changes
docs/book/src/user/quick-start.md Outdated
@@ -101,7 +101,10 @@ The clusterctl CLI tool handles the lifecycle of a Cluster API management cluste
#### Install clusterctl binary with curl on linux
Download the latest release; on linux, type:
```
curl -L {{#releaselink gomodule:"sigs.k8s.io/cluster-api" asset:"clusterctl-linux-amd64" version:"1.0.x"}} -o clusterctl
curl -L {{#releaselink gomodule:"sigs.k8s.io/cluster-api" asset:"clusterctl-linux-amd64" version:"1.x"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joekr I don't think we should drop the minor version, given that the code will be moved in a branch and the book version generated on top of it should match the same branch.
Also, somehow related, before fixing this we should figure out #6017
@sbueringer are there updates from netlify?

Copy link
Member

@sbueringer sbueringer Feb 15, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, somehow related, before fixing this we should figure out #6017
@sbueringer are there updates from netlify?

I didn't get a reply-mail, maybe @CecileRobertMichon

Good point, but think it should be fine to change it to 1.1.x already though to get the current book fixed. I would prefer if we have a 1.1 version there now (and cherry-pick to release-1.1). The release-1.0 branch will then still produce a book with links to 1.0.x

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@joekr joekr force-pushed the update-book-install branch from 082c2c6 to a2b6e66 Compare February 15, 2022 18:25
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 15, 2022
@joekr joekr force-pushed the update-book-install branch from a2b6e66 to a09dbf5 Compare February 15, 2022 18:26
joekr
joekr commented Feb 15, 2022
View reviewed changes
docs/book/src/user/quick-start.md Outdated
@@ -101,7 +101,10 @@ The clusterctl CLI tool handles the lifecycle of a Cluster API management cluste
#### Install clusterctl binary with curl on linux
Download the latest release; on linux, type:
```
curl -L {{#releaselink gomodule:"sigs.k8s.io/cluster-api" asset:"clusterctl-linux-amd64" version:"1.0.x"}} -o clusterctl
curl -L {{#releaselink gomodule:"sigs.k8s.io/cluster-api" asset:"clusterctl-linux-amd64" version:"1.1.x"
prereleases:"true"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to remove this. was for testing 😮‍💨

@joekr joekr force-pushed the update-book-install branch from a09dbf5 to 01b597c Compare February 15, 2022 18:50
sbueringer
sbueringer reviewed Feb 15, 2022
View reviewed changes
docs/book/src/user/quick-start.md Outdated
@@ -101,7 +101,7 @@ The clusterctl CLI tool handles the lifecycle of a Cluster API management cluste
#### Install clusterctl binary with curl on linux
Download the latest release; on linux, type:
```
curl -L {{#releaselink gomodule:"sigs.k8s.io/cluster-api" asset:"clusterctl-linux-amd64" version:"1.0.x"}} -o clusterctl
curl -L {{#releaselink gomodule:"sigs.k8s.io/cluster-api" asset:"clusterctl-linux-amd64" version:"1.1.x" }} -o clusterctl
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
curl -L {{#releaselink gomodule:"sigs.k8s.io/cluster-api" asset:"clusterctl-linux-amd64" version:"1.1.x" }} -o clusterctl
curl -L {{#releaselink gomodule:"sigs.k8s.io/cluster-api" asset:"clusterctl-linux-amd64" version:"1.1.x"}} -o clusterctl

last nit

@joekr joekr force-pushed the update-book-install branch from 01b597c to 8f82de9 Compare February 15, 2022 19:19
@sbueringer
Copy link
Member

/lgtm

I think independent of how we keep/change our book versioning this is a good fix for main (and also to cherry-pick into release-1.1)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 15, 2022
@sbueringer
Copy link
Member

sbueringer commented Feb 15, 2022 •
edited
Loading

@joekr Can you please look into signing the CLA via EasyCLA? (#6137 (comment))

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 15, 2022
killianmuldoon
killianmuldoon approved these changes Feb 15, 2022
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@fabriziopandini
Copy link
Member

@joekr congrats on your first PR in CAPI 🥳 !
/lgtm
/approve

/cherry-pick release-1.1

@k8s-infra-cherrypick-robot
Copy link

@fabriziopandini: once the present PR merges, I will cherry-pick it on top of release-1.1 in a new PR and assign it to you.

In response to this:

@joekr congrats on your first PR in CAPI 🥳 !
/lgtm
/approve

/cherry-pick release-1.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 16, 2022
@fabriziopandini
Copy link
Member

@sbueringer should this go in our release task?

@k8s-ci-robot k8s-ci-robot merged commit 4586b16 into kubernetes-sigs:main Feb 16, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.2 milestone Feb 16, 2022
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Feb 16, 2022
Merged
@k8s-infra-cherrypick-robot
Copy link

@fabriziopandini: new pull request created: #6148

In response to this:

@joekr congrats on your first PR in CAPI 🥳 !
/lgtm
/approve

/cherry-pick release-1.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbueringer sbueringer mentioned this pull request Feb 16, 2022
Closed
17 tasks
@sbueringer
Copy link
Member

@sbueringer should this go in our release task?

Good point. Done

@ykakarap ykakarap mentioned this pull request Jun 9, 2022
Closed
23 tasks
@joekr joekr mentioned this pull request Jun 13, 2022
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@sbueringer sbueringer sbueringer left review comments

@killianmuldoon killianmuldoon killianmuldoon approved these changes

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

Assignees

@sbueringer sbueringer

@fabriziopandini fabriziopandini

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.
6 participants
@joekr @k8s-ci-robot @sbueringer @fabriziopandini @k8s-infra-cherrypick-robot @killianmuldoon