Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Improve version support documentation #6122

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:
Improving version support matrix to better surface the practices we are following.
TL;DR; we try to go over and behind Kubernetes support matrix to meet the users where they are, but at the same time there should be boundaries to what we can reasonably support/validate with our CI signal.

Which issue(s) this PR fixes:
Fixes #4444

/cc @CecileRobertMichon @vincepri @enxebre @sbueringer

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 14, 2022
docs/book/src/reference/versions.md Outdated Show resolved Hide resolved
docs/book/src/reference/versions.md Outdated Show resolved Hide resolved
docs/book/src/reference/versions.md Outdated Show resolved Hide resolved
docs/book/src/reference/versions.md Outdated Show resolved Hide resolved
@fabriziopandini fabriziopandini force-pushed the improve-version-support-matrix branch from 2c0cf77 to a012eb6 Compare February 14, 2022 16:36
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 14, 2022
@fabriziopandini fabriziopandini force-pushed the improve-version-support-matrix branch from a012eb6 to d257846 Compare February 14, 2022 16:40
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 14, 2022
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2022
@sbueringer
Copy link
Member

Sounds great.
/lgtm

/hold
@fabriziopandini in case you want to squash before merge

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 14, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 14, 2022
@fabriziopandini fabriziopandini force-pushed the improve-version-support-matrix branch from d257846 to d96a6d0 Compare February 16, 2022 17:45
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 16, 2022
Copy link
Contributor

@stmcginnis stmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 16, 2022
@enxebre
Copy link
Member

enxebre commented Feb 16, 2022

/lgtm

@vincepri
Copy link
Member

/hold cancel
/approve

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 17, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 422f420 into kubernetes-sigs:main Feb 17, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.2 milestone Feb 17, 2022
@fabriziopandini
Copy link
Member Author

/cherry-pick release-1.1
given that this can help the users to better understand our support matrix

@k8s-infra-cherrypick-robot

@fabriziopandini: new pull request created: #6175

In response to this:

/cherry-pick release-1.1
given that this can help the users to better understand our support matrix

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fabriziopandini fabriziopandini deleted the improve-version-support-matrix branch March 1, 2022 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define a policy for Kubernetes version support for workload clusters
8 participants