🌱 [controllers/external] Accept narrower interfaces #6099
Conversation
The Get function only uses methods defined in client.Reader. The Delete function only uses methods defined in client.Writer. Therefore they can accept client.Reader and client.Writer, instead of client.Client, which combines both client.Reader and client.Writer. This change allows callers that can only pass in a client.Reader or client.Writer.
k8s-ci-robot
added
cncf-cla: yes
dlipovetsky
changed the title
|
@dlipovetsky: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
(Although aipdiff fails, I think the change is backward compatible, since all callers currently pass in a |
|
Thx! /lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enxebre The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
What this PR does / why we need it:
The Get function only uses methods defined in client.Reader.
The Delete function only uses methods defined in client.Writer.
Therefore they can accept client.Reader and client.Writer, instead
of client.Client, which combines both client.Reader and client.Writer.
This change allows callers that can only pass in a client.Reader
or client.Writer.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #