-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Force rebuild of tilt-prepare #6082
✨ Force rebuild of tilt-prepare #6082
Conversation
Signed-off-by: Johannes Frey <[email protected]>
Welcome @johannesfrey! |
Hi @johannesfrey. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test Thank you very much! I know we are changing tilt-prepare only once in a while, but there are some change like the cert-manager thing or #6079. Whenever we have a change like this, it becomes an additional hurdle for folks who are not familiar with the details of our tilt setup because they are confronted with some strange errors. So huge +1 from my side :) P.S. Now that we are sure that tilt-prepare is always up-to-date, we could add version checks for kustomize/envsubst/helm in tilt-prepare which can produce user-understandable errors. But I would only consider this if we run into compatibility issues there in the future. |
/lgtm |
@johannesfrey thanks for your first CAPI PR! 🥳 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR forces a rebuild of the tilt-prepare binary when running
tilt up
in order to incorporate code changes. Recent example: The cert-manager repo moved to another location but this change did not reflect in tilt-prepare when it was already built beforehand.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #6077
Signed-off-by: Johannes Frey [email protected]
Johannes Frey <[email protected]>, Daimler TSS GmbH (Provider Information)