-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix cert manager repo and add troubleshooting guide #6050
🐛 Fix cert manager repo and add troubleshooting guide #6050
Conversation
a3e36d1
to
cda30d8
Compare
This is a breaking change according to the api diff bot 😵💫. I'll deprecate and add a new constant. |
cda30d8
to
1d79134
Compare
eeb1fab
to
f503ae3
Compare
Signed-off-by: killianmuldoon <[email protected]>
f503ae3
to
98e3f97
Compare
@killianmuldoon: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
apidiff is failing due to changing the value of the constant. The book lists a different compatibility guarantee for clusterctl (which this change is entirely inside of). IMO its better to change this constant, and update anyone who might be consuming it to the correct version, than to keep it to pass the apidiff. |
/lgtm |
@fabriziopandini: once the present PR merges, I will cherry-pick it on top of release-1.1 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@fabriziopandini: new pull request created: #6052 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: killianmuldoon [email protected]
Update cert manger URL and add a troubleshooting section for older versions of CAPI. This PR fixes an issue where a change in the location of the cert manager repo prevented clusterctl init from working.
Fixes: #6051