🐛 Fix flaky Test_objectMover #6046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
the
size/L
sbueringer
force-pushed
the
pr-fix-object-mover-test
branch
2 times, most recently
from
f84ec08 to
79a8c5a
Compare
k8s-ci-robot
added
size/S
sbueringer
force-pushed
the
pr-fix-object-mover-test
branch
from
79a8c5a to
b40a09b
Compare
|
/retest |
sbueringer
force-pushed
the
pr-fix-object-mover-test
branch
from
b40a09b to
607a1c5
Compare
Jont828
reviewed
Feb 2, 2022
| @@ -707,7 +724,7 @@ func Test_objectMover_backupTargetObject(t *testing.T) { | |||
| time.Sleep(time.Millisecond * 5) | |||
There was a problem hiding this comment.
@sbueringer I mentioned this in Slack too, but I was able to fix the test on my machine by changing the duration here.
Suggested change
| time.Sleep(time.Millisecond * 5) | |
| time.Sleep(time.Millisecond * 50) |
There was a problem hiding this comment.
Thx. Let's just try that and then we see over the next weeks/months if the flake still occurs.
Signed-off-by: Stefan Büringer [email protected]
sbueringer
force-pushed
the
pr-fix-object-mover-test
branch
from
607a1c5 to
a7eed44
Compare
k8s-ci-robot
added
size/XS
sbueringer
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/assign @killianmuldoon @fabriziopandini |
killianmuldoon
approved these changes
Feb 3, 2022
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stefan Büringer [email protected]
What this PR does / why we need it:
Based on the Slack discussion (https://kubernetes.slack.com/archives/C8TSNPY4T/p1643414553424199) increasing the timeout has a chance to solve the flake. Let's try it.
Thx @Jont828 !
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #5938