-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 book: Use relative links in generate CRDs doc #6030
📖 book: Use relative links in generate CRDs doc #6030
Conversation
Signed-off-by: Stefan Büringer [email protected]
@fabriziopandini I've opened this PR to get the discussion started on how we want to fix it. I think we don't have to backport the whole #6018 PR as we don't want to v1.1=>v1.2 doc and we don't have to rename the old migration guides. Instead I propose to make the links in the generate CRDs doc relative. This fix is cherry-pick'able to release-0.3 and release-0.4 as this section of the generate CRDs doc didn't change since release-0.3. WDYT? |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-0.3 |
/cherry-pick release-1.0 |
@sbueringer: #6030 failed to apply on top of branch "release-0.3":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@sbueringer: new pull request created: #6034 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-0.4 |
@sbueringer: new pull request created: #6035 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Stefan Büringer [email protected]
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #