🌱 Upgrade to golangci-lint v1.44 and fix findings

[sbueringer]

Signed-off-by: Stefan Büringer [email protected]

What this PR does / why we need it:

This PR upgrades golangci-lint to v1.44 and adds the new containedctx linter (for context, see: # https://go.dev/blog/context-and-structs)

I also looked at the other new linters in the release notes, but I don't think we should add one of them:

• decorder: Sounds too opinionated
• errchkjson: If I got it right, it would allow ignoring errors on e.g. json.Marshal if it's safe. Not sure if we need/want that.
• maintidx: Checks for maintainability (similar to gocyclo). Based on their doc it's an "an experimental value". It would currently only complains about our ClusterctlUpgradeSpec test. I think let's just continue using gocyclo for now.
• grouper: Can enforce grouping. I think we have a few other linters which e.g. force correct grouping of imports.

xref: golangci-lint release notes: https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md#v1440

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

[sbueringer]

/cc @stmcginnis @fabriziopandini @vincepri

[stmcginnis]

/lgtm

Updates all seem reasonable.

[enxebre]

for ref https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md#v1440
/lgtm

[sbueringer]

for ref https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md#v1440 /lgtm

Thx, I also added it to the PR description

[sbueringer]

Thx for the reviews!
I added a comment above the testFunc hacks to link the issue I opened in thelper, so we'll hopefully can get rid of it after the issue is fixed there.

I also took a look at all new linters and added the containectx linter. I added some notes in the PR description about the others. Originally I wanted to open a separate PR, but as it's only enabling that one linter (which sounds reasonable) and no code changes, I think it's okay to include it in this PR.

[stmcginnis]

Changes still look good to me. Thanks for adding linter analysis in the PR description, that could be a helpful reference in the future.

/lgtm

[vincepri]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vincepri]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment