-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 documentation for clusterctl alpha topology plan
#6009
📖 documentation for clusterctl alpha topology plan
#6009
Conversation
clusterctl alpha topology plan
53ecf8d
to
b6a44fa
Compare
xref: #5953 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
One potential additional use case could be modifying something in the Cluster topology while the ClusterClass stays the same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That a great start!
Main comments
- let's drop dry run and use plan
- let's move Reference at the end (as well as the notes about corners cases/details)
- let's add two use cases
- change topology
- rebase
b6a44fa
to
81fe29c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great!
last round of nits from my side (and you can remove WIP as well)
clusterctl alpha topology plan
clusterctl alpha topology plan
81fe29c
to
364fdcb
Compare
/lgtm |
364fdcb
to
390251a
Compare
Thx, great work! I think it explains very nicely what you can achieve with the topology plan command /lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-1.1 |
@fabriziopandini: new pull request created: #6023 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
Adds documentation for the new
clusterctl alpha topology plan
command.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #