Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Upgrade to Kubernetes 1.23.3 in Quickstart and CI #5999

Merged
merged 1 commit into from
Jan 27, 2022
Merged

✨ Upgrade to Kubernetes 1.23.3 in Quickstart and CI #5999

merged 1 commit into from
Jan 27, 2022

Conversation

MartinForReal
Copy link
Contributor

@MartinForReal MartinForReal commented Jan 26, 2022

What this PR does / why we need it:
Upgrade to Kubernetes 1.23.3 in Quickstart and CI

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Partially implements #5995

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 26, 2022
@MartinForReal MartinForReal changed the title ✨:sparkles: Upgrade to Kubernetes 1.23.3 in Quickstart and CI ✨ Upgrade to Kubernetes 1.23.3 in Quickstart and CI Jan 26, 2022
@MartinForReal
Copy link
Contributor Author

/assign @timothysc

@sbueringer
Copy link
Member

@MartinForReal
Thx, that was quick! :)

/lgtm
/assign @fabriziopandini
TBD if we want to cherry-pick to release-1.1.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 26, 2022
@sbueringer
Copy link
Member

@MartinForReal
Can you please change "Fixes #5995" to something like "Partially implements #5995". Just so that the issue is not closed automatically, as we also need a PR to test-infra to close it.

@MartinForReal
Copy link
Contributor Author

@MartinForReal Shangxiang Fan FTE Can you please change "Fixes #5995" to something like "Partially implements #5995". Just so that the issue is not closed automatically, as we also need a PR to test-infra to close it.

Sure. Updated

Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!
only a tiny suggestion from my side

KUBERNETES_VERSION_MANAGEMENT: "v1.23.0"
KUBERNETES_VERSION: "v1.23.0"
KUBERNETES_VERSION_MANAGEMENT: "v1.23.3"
KUBERNETES_VERSION: "v1.23.3"
KUBERNETES_VERSION_UPGRADE_FROM: "v1.22.4"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about picking up also latest from v1.22 given that we are at it...

Suggested change
KUBERNETES_VERSION_UPGRADE_FROM: "v1.22.4"
KUBERNETES_VERSION_UPGRADE_FROM: "v1.22.6"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I see correctly there is no published image for v1.22.6 (https://hub.docker.com/r/kindest/node/tags) which means the job which uses that version has to build v1.22.6 every time.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fair point, let's hold on this

@sbueringer
Copy link
Member

sbueringer commented Jan 26, 2022

@fabriziopandini Not sure if want to cherry-pick. I would slightly favor yes.

I think it would be good to use v1.23.3 in the quickstart in the v1.1.0 book and in CAPD, given that the older Kubernetes versions have that issue with CRDs.

@fabriziopandini
Copy link
Member

/approve
/lgtm

/cherry-pick v1.1
given that we are picking up the recommended version from K8s

@k8s-infra-cherrypick-robot

@fabriziopandini: once the present PR merges, I will cherry-pick it on top of v1.1 in a new PR and assign it to you.

In response to this:

/approve
/lgtm

/cherry-pick v1.1
given that we are picking up the recommended version from K8s

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2022
@sbueringer
Copy link
Member

/test pull-cluster-api-test-mink8s-main

known flake

@k8s-ci-robot k8s-ci-robot merged commit 5dc0ab2 into kubernetes-sigs:main Jan 27, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.2 milestone Jan 27, 2022
@k8s-infra-cherrypick-robot

@fabriziopandini: cannot checkout v1.1: error checking out v1.1: exit status 1. output: error: pathspec 'v1.1' did not match any file(s) known to git

In response to this:

/approve
/lgtm

/cherry-pick v1.1
given that we are picking up the recommended version from K8s

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbueringer
Copy link
Member

/cherry-pick release-1.1

@k8s-infra-cherrypick-robot

@sbueringer: new pull request created: #6012

In response to this:

/cherry-pick release-1.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants