-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Upgrade to Kubernetes 1.23.3 in Quickstart and CI #5999
Conversation
Signed-off-by: MartinForReal <[email protected]>
/assign @timothysc |
@MartinForReal /lgtm |
@MartinForReal |
Sure. Updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
only a tiny suggestion from my side
KUBERNETES_VERSION_MANAGEMENT: "v1.23.0" | ||
KUBERNETES_VERSION: "v1.23.0" | ||
KUBERNETES_VERSION_MANAGEMENT: "v1.23.3" | ||
KUBERNETES_VERSION: "v1.23.3" | ||
KUBERNETES_VERSION_UPGRADE_FROM: "v1.22.4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about picking up also latest from v1.22 given that we are at it...
KUBERNETES_VERSION_UPGRADE_FROM: "v1.22.4" | |
KUBERNETES_VERSION_UPGRADE_FROM: "v1.22.6" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sbueringer ^^
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I see correctly there is no published image for v1.22.6 (https://hub.docker.com/r/kindest/node/tags) which means the job which uses that version has to build v1.22.6 every time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fair point, let's hold on this
@fabriziopandini Not sure if want to cherry-pick. I would slightly favor yes. I think it would be good to use v1.23.3 in the quickstart in the v1.1.0 book and in CAPD, given that the older Kubernetes versions have that issue with CRDs. |
/approve /cherry-pick v1.1 |
@fabriziopandini: once the present PR merges, I will cherry-pick it on top of v1.1 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-cluster-api-test-mink8s-main known flake |
@fabriziopandini: cannot checkout In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-1.1 |
@sbueringer: new pull request created: #6012 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
Upgrade to Kubernetes 1.23.3 in Quickstart and CI
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Partially implements #5995