🌱 linter: enable noctx and unused #5959
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
sbueringer
force-pushed
the
pr-enable-linters
branch
from
b1cd72e to
70004ef
Compare
k8s-ci-robot
added
size/L
sbueringer
force-pushed
the
pr-enable-linters
branch
from
70004ef to
a693c96
Compare
k8s-ci-robot
added
size/M
| @@ -341,28 +341,6 @@ func dockerContainerToContainer(container *types.Container) Container { | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Those methods were unused, both also exist as funcs which are used.
There was a problem hiding this comment.
Oops, I must have done that while moving things around. Thanks for cleaning that up!
There was a problem hiding this comment.
Thought so, you're welcome :)
Signed-off-by: Stefan Büringer [email protected]
sbueringer
force-pushed
the
pr-enable-linters
branch
from
a693c96 to
3d2876c
Compare
k8s-ci-robot
added
size/L
|
/cc @fabriziopandini |
| @@ -144,7 +147,12 @@ func downloadFile(url string, filepath string) error { | |||
| Timeout: 30 * time.Second, | |||
There was a problem hiding this comment.
We could move this timeout to the context now, but reading through recommended practices, I think in this case either way works for our needs.
| @@ -341,28 +341,6 @@ func dockerContainerToContainer(container *types.Container) Container { | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Oops, I must have done that while moving things around. Thanks for cleaning that up!
k8s-ci-robot
added
the
lgtm
|
/assign @fabriziopandini |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Signed-off-by: Stefan Büringer [email protected]
What this PR does / why we need it:
This PR proposes to enable two new linters:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #