-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 ClusterClass: restructure documentation #5954
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall lgtm, only tiny nits
docs/book/src/SUMMARY.md
Outdated
- [Changing a ClusterClass](./tasks/experimental-features/cluster-class/change-clusterclass.md) | ||
- [Operating a Cluster](./tasks/experimental-features/cluster-class/operate-cluster.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be
- [Operating a Cluster](./tasks/experimental-features/cluster-class/operate-cluster.md) | |
- [Operating a Managed Cluster](./tasks/experimental-features/cluster-class/operate-cluster.md) |
or "Operating a Cluster using Managed Topology"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, change the title inside the linked page and add a subtitle "Upgrade the Cluster" on top of the current content
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, updated
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):First step of #5953