🐛 Make MHC ClusterClass authoritative on paths

[killianmuldoon]

Signed-off-by: killianmuldoon [email protected]

Fixes #5948

[killianmuldoon]

The latest version now calls the defaulting method as a last step in its computation. This means there should never be a field set during defaulting which is unset on a desired MHC. The Cluster Topology controller is still authoritative on the whole "spec" of the object.

[sbueringer]

@killianmuldoon
Overall looks good. But maybe we should inline the mhcBuilder now? It makes it very hard to assess if the tests are correct without inlining.

[killianmuldoon]

I can do it in this PR and if not one pre-release. It's on my list 😄 . It'll take a couple of days though I think, given other priorities.

[sbueringer]

I can do it in this PR and if not one pre-release. It's on my list 😄 . It'll take a couple of days though I think, given other priorities.

Okay then let's do that as follow-up

[sbueringer]

Tested the scenario from the issue and a few more locally with this PR and everything behaves as expected now!

/lgtm

[fabriziopandini]

@killianmuldoon thanks for sorting out this detail
It is a small thing but it makes the user experience much more intuitive.
/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [fabriziopandini]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment