Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 block +2 minor version upgrade in cluster topology #5935

Merged
merged 1 commit into from
Jan 17, 2022
Merged

🌱 block +2 minor version upgrade in cluster topology #5935

merged 1 commit into from
Jan 17, 2022

Conversation

ykakarap
Copy link
Contributor

What this PR does / why we need it:

This PR blocks +2 minor version upgrade of kubernetes version in clusters with managed topologies.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #5853

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 13, 2022 •
edited
Loading

CLA Signed

The committers are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 13, 2022
ykakarap
ykakarap commented Jan 13, 2022
View reviewed changes
Copy link
Contributor Author

@ykakarap ykakarap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I also note this in the ClusterClass proposal doc?

sbueringer
sbueringer reviewed Jan 13, 2022
View reviewed changes
Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just nits

docs/book/src/tasks/experimental-features/cluster-class/upgrade-cluster.md Outdated Show resolved Hide resolved
internal/webhooks/cluster.go Outdated Show resolved Hide resolved
@fabriziopandini
Copy link
Member

lgtm pending comments

@ykakarap ykakarap force-pushed the block_2_minor_upgrades branch from f158993 to 4d3c687 Compare January 16, 2022 17:53
@sbueringer
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 17, 2022
@fabriziopandini
Copy link
Member

/approve

@ykakarap Please check your easy CLA with the CNCF team because it will get mandatory starting the 5th of February

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2022
@ykakarap
Copy link
Contributor Author

Did something recently change with https://discuss.kubernetes.io/c/contributors/cluster-api ?

The above link is throwing a 404 and the markdown link checker is complaining about it.

@sbueringer
Copy link
Member

Did something recently change with https://discuss.kubernetes.io/c/contributors/cluster-api ?

The above link is throwing a 404 and the markdown link checker is complaining about it.

I'm not sure. But I would open a PR to drop it for now and probably an issue to discuss what happened / if we want to re-introduce it.

@sbueringer sbueringer mentioned this pull request Jan 17, 2022
Merged
@sbueringer
Copy link
Member

@ykakarap I'll try to address it in: #5943 (comment)

killianmuldoon
killianmuldoon approved these changes Jan 17, 2022
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ykakarap ykakarap force-pushed the block_2_minor_upgrades branch from 4d3c687 to 3f1efe5 Compare January 17, 2022 13:05
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 17, 2022
@sbueringer
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 17, 2022
@k8s-ci-robot k8s-ci-robot merged commit 32c2c16 into kubernetes-sigs:main Jan 17, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.1 milestone Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbueringer sbueringer sbueringer left review comments

@killianmuldoon killianmuldoon killianmuldoon approved these changes

@CecileRobertMichon CecileRobertMichon Awaiting requested review from CecileRobertMichon

@stmcginnis stmcginnis Awaiting requested review from stmcginnis

Assignees

@sbueringer sbueringer

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.1
Development

Successfully merging this pull request may close these issues.

Upgrade to +2 minor version on a managed topology fails when using KCP
5 participants
@ykakarap @fabriziopandini @sbueringer @k8s-ci-robot @killianmuldoon