✨ ClusterClass: implement MachineDeployment variable overrides #5928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
sbueringer
force-pushed
the
pr-md-variables
branch
2 times, most recently
from
1ea05c1 to
d52d7ab
Compare
sbueringer
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
sbueringer
force-pushed
the
pr-md-variables
branch
from
d52d7ab to
82fed5c
Compare
internal/controllers/topology/cluster/patches/variables/variables.go
Outdated
Show resolved
Hide resolved
k8s-ci-robot
added
the
needs-rebase
Signed-off-by: Stefan Büringer [email protected]
sbueringer
force-pushed
the
pr-md-variables
branch
from
f21c879 to
11f8de9
Compare
k8s-ci-robot
removed
the
needs-rebase
sbueringer
force-pushed
the
pr-md-variables
branch
from
11f8de9 to
a763938
Compare
|
Thx for the review, findings should be fixed. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
I've done a good bit of manual testing on this locally and it works as advertised 🚀 . I took a quick review of the code and it looks good - just one nit. I'll come back and do a fuller review if I have time. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stefan Büringer [email protected]
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #5927