-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 test/e2e/cluster-upgrade: skip worker upgrades if worker count is 0 #5926
🐛 test/e2e/cluster-upgrade: skip worker upgrades if worker count is 0 #5926
Conversation
Signed-off-by: Stefan Büringer [email protected]
/test pull-cluster-api-verify-main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thank you @sbueringer for the super fast fix |
@fabriziopandini do we need to backport this to include it in release 1.1 since the beta release tag already exists or will everything in main be included? |
I think we don't. I expect the release to be cut from current main as there is no release-1.1 branch yet and I think it will be created from main at the time of the release. But let's see what Fabrizio says of course :) |
the 1.1 branch does not exist yet, it will be created when we cut the release; it makes sense to cut an rc to allow providers to get this before the release (we should get a couple of PR in before...) |
Signed-off-by: Stefan Büringer [email protected]
What this PR does / why we need it:
Currently, the cluster upgrade test fails when the worker count is 0 (#4896 (comment)). This PR makes sure we skip the upgrade of MachineDeployments and MachinePools in that case.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #