🐛 ClusterClass: allow accessing nestedFields via valueFrom.variable #5925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Büringer [email protected]
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
sbueringer
commented
Jan 11, 2022
| // validating if the whole path is an existing variable. | ||
| // This could be done by re-using getVariableValue of the json patch | ||
| // generator but requires a refactoring first. | ||
| variableName := getVariableName(*jsonPatch.ValueFrom.Variable) |
There was a problem hiding this comment.
I'm aware that we're duplicating more logic here, similar to how we did above with the builtin variable validation.
But I think for now it's the pragmatic thing to do. I think long-term we should clean it up so that the webhook can re-use code of the JSON patch generator for validation to allow more powerful validations (and less duplicate code/logic).
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stefan Büringer [email protected]
What this PR does / why we need it:
With this PR it's now possible to access nested fields of complex variables (objects and arrays) via
.valueFrom.variable. This was already implemented in the JSON patch generator, but blocked by the webhook.I think complex variables and the Patch validation were implemented at the same time so we missed it.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #