Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Add timeout to check if KCP object exists #5907

Merged

Conversation

namnx228
Copy link
Contributor

@namnx228 namnx228 commented Jan 5, 2022

This is a manual cherry-pick of #5889
/assign @fabriziopandini

@k8s-ci-robot k8s-ci-robot added this to the v0.4 milestone Jan 5, 2022
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 5, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @namnx228. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 5, 2022
@fabriziopandini
Copy link
Member

/hold
before landing in v0.4 branch, the PR should be cherry-picked into the v1.0 branch; also, could you provide a rationale about why this cherry-pick is required?

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 5, 2022
@namnx228
Copy link
Contributor Author

namnx228 commented Jan 5, 2022

/hold before landing in v0.4 branch, the PR should be cherry-picked into the v1.0 branch; also, could you provide a rationale about why this cherry-pick is required?

This cherry pick is needed because the issue described in #5889 also happens in v0.4.
I will open another PR to cherry pick this commit to v1.0

@sbueringer
Copy link
Member

sbueringer commented Jan 5, 2022

/ok-to-test

Cherry-pick is fine for me, given that it's otherwise hard for providers who have this issue and use 1.0 (same for 0.4) to get a stable CI without this fix.
#5909 (comment)

/lgtm
pending the hold & that the 1.0 cherry-pick is merged first

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 5, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 5, 2022
@sbueringer
Copy link
Member

/retitle 🌱 Add timeout to check if KCP object exists

@k8s-ci-robot k8s-ci-robot changed the title Add timeout to check if KCP object exists 🌱 Add timeout to check if KCP object exists Jan 5, 2022
@sbueringer
Copy link
Member

sbueringer commented Jan 5, 2022

/hold cancel
/lgtm

given that the 1.0 cherry-pick has been merged too

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 5, 2022
@fabriziopandini
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2022
@k8s-ci-robot k8s-ci-robot merged commit 7109fa5 into kubernetes-sigs:release-0.4 Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants