-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Fix adding appended list directly causing changing previous value #5877
🌱 Fix adding appended list directly causing changing previous value #5877
Conversation
Baclport of kubernetes-sigs#5670 to v1alpha4 API in release-0.4 branch.
Hi @fmuyassarov. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@fmuyassarov is this a duplicate of #5876 ? |
/hold |
Ops, yes :) I missed your cherry pick PR. Closing this and thanks again for the quick response. |
/close since this a duplicate |
/close |
Baclport of #5670 to v1alpha4 API in release-0.4 branch.
What this PR does / why we need it:
Original paths will use appended list directly, this works fine when there is fewer recursion, or there is only one for loop for the diff, but if there are multiple loop, second loop would override the first added array.
Thus I'm creating a new tmp array to do a deepcopy, then add this appended value into allPaths.