-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Prevent orphaned InfrastructureMachines #5865
🐛 Prevent orphaned InfrastructureMachines #5865
Conversation
bcb16b5
to
c934cd0
Compare
c934cd0
to
e8592c3
Compare
/test pull-cluster-api-e2e-full-main |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Q: should we backport this? @vincepri @sbueringer |
I see benefit in backporting this change to the earlier releases. I have seen this issue prop up in multiple environments using previous versions. Plus the change only adds another owner ref without affecting the flow of object reconciliation. |
/cherry-pick release-1.0 |
@fabriziopandini: new pull request created: #5875 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
This PR prevents CAPI to leave orphaned InfrestructureMachines when a MachineSet creates a machine that gets deleted before the controllers setting ownerRef to the corresponding InfrastructureMachines.
This is achieved by setting an additional ownerRef to the MachineSet, thus triggering InfrestructureMachines cleanup when the MS gets deleted.
Which issue(s) this PR fixes:
Fixes #5483