Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Add unlock if bootstrap machine holding lock does not exist #5856

Merged
merged 1 commit into from
Dec 13, 2021
Merged

🐛 Add unlock if bootstrap machine holding lock does not exist #5856

merged 1 commit into from
Dec 13, 2021

Conversation

k8s-infra-cherrypick-robot
Copy link

This is an automated cherry-pick of #5855

/assign fabriziopandini

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Dec 13, 2021
Merged
@k8s-ci-robot k8s-ci-robot added this to the v0.4 milestone Dec 13, 2021
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 13, 2021
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 13, 2021
@vincepri vincepri changed the title [release-0.4] 🐛 Add unlock if bootstrap machine holding lock does not exist 🐛 Add unlock if bootstrap machine holding lock does not exist Dec 13, 2021
vincepri
vincepri approved these changes Dec 13, 2021
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 13, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 13, 2021
@fabriziopandini
Copy link
Member

/retest

@fabriziopandini
Copy link
Member

/cherry-pick release-0.3

@k8s-infra-cherrypick-robot
Copy link
Author

@fabriziopandini: once the present PR merges, I will cherry-pick it on top of release-0.3 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot merged commit 81365ad into kubernetes-sigs:release-0.4 Dec 13, 2021
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Dec 13, 2021
Closed
@k8s-infra-cherrypick-robot
Copy link
Author

@fabriziopandini: new pull request created: #5857

In response to this:

/cherry-pick release-0.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@killianmuldoon killianmuldoon mentioned this pull request Dec 14, 2021
Closed
@killianmuldoon
Copy link
Contributor

Merged to fix #5814 for releases 0.4.X.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincepri vincepri vincepri approved these changes

@enxebre enxebre Awaiting requested review from enxebre

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

Assignees

@vincepri vincepri

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.4
Development

Successfully merging this pull request may close these issues.
5 participants
@k8s-infra-cherrypick-robot @k8s-ci-robot @fabriziopandini @killianmuldoon @vincepri