Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 Update ClusterClass proposal #5838

Merged
merged 1 commit into from
Dec 10, 2021
Merged

📖 Update ClusterClass proposal #5838

merged 1 commit into from
Dec 10, 2021

Conversation

sbueringer
Copy link
Member

Signed-off-by: Stefan Büringer [email protected]

What this PR does / why we need it:
This PR updates the proposal based on recent developments.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@sbueringer
Update ClusterClass proposal
0b454d6 
Signed-off-by: Stefan Büringer [email protected]
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 9, 2021
killianmuldoon
killianmuldoon approved these changes Dec 9, 2021
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 9, 2021
@killianmuldoon
Copy link
Contributor

I thought about needing to add examples and descriptions here, but I don't think they really need to be covered in the proposal at this stage.

@sbueringer
Copy link
Member Author

sbueringer commented Dec 9, 2021 •
edited
Loading

I thought about needing to add examples and descriptions here, but I don't think they really need to be covered in the proposal at this stage.

I would have added them, but they are part of the JSONSchemaProps which is not part of the proposal currently :) (which is probably a good thing)

(I added the description for patches though)

fabriziopandini
fabriziopandini reviewed Dec 9, 2021
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

vincepri
vincepri approved these changes Dec 10, 2021
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Thank you!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 10, 2021
@sbueringer
Copy link
Member Author

/test pull-cluster-api-test-mink8s-main

@k8s-ci-robot k8s-ci-robot merged commit c698e19 into kubernetes-sigs:main Dec 10, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.1 milestone Dec 10, 2021
@sbueringer sbueringer deleted the pr-update-cc-proposal branch December 10, 2021 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@killianmuldoon killianmuldoon killianmuldoon approved these changes

@vincepri vincepri vincepri approved these changes

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@stmcginnis stmcginnis Awaiting requested review from stmcginnis

Assignees

@fabriziopandini fabriziopandini

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.1
Development

Successfully merging this pull request may close these issues.
5 participants
@sbueringer @killianmuldoon @k8s-ci-robot @vincepri @fabriziopandini