[clusterctl] add phases for apply-machines and apply-cluster #581
Conversation
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
size/XL
| if err != nil { | ||
| return fmt.Errorf("unable to ensure namespace %q in bootstrap cluster: %v", cluster.Namespace, err) | ||
| } | ||
|
|
||
| glog.Info("Applying Cluster API stack to bootstrap cluster") | ||
| if err := phases.ApplyClusterAPIComponents(bootstrapClient, d.providerComponents); err != nil { |
There was a problem hiding this comment.
ApplyClusterAPIComponents doesn't include the client.EnsureNamespace(namespace) call which used to proceed it. Will it now fail if the namespace doesn't exist? Does it also need to include that call in it's phase?
There was a problem hiding this comment.
This gets a bit tricky, since post-CRD migration we are not deploying the cluster-api (or provider) components in the default namespace and the namespace creation is added as part of the manager config (at least for the common cluster-api components, aws provider, and gcp provider).
I'm good with re-adding it if there is a provider that depends on this behavior or if there is another use case that I am missing where it is relied upon, but afaict the default/cluster namespace validation is only needed for the cluster, machine creation, and possibly the provider-components config map steps at this point.
There was a problem hiding this comment.
sgtm to remove it for now, and we can re-add if we need to.
detiber
force-pushed
the
phases4
branch
2 times, most recently
from
5231079 to
42a4020
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: detiber, roberthbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
What this PR does / why we need it:
clusterctl alpha phase apply-clusterclusterctl alpha phase apply-machinesWhich issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Related to #554
Release note: