-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 CAPD: add ClusterClass cluster-template #5805
🌱 CAPD: add ClusterClass cluster-template #5805
Conversation
@@ -78,6 +66,18 @@ spec: | |||
--- | |||
apiVersion: infrastructure.cluster.x-k8s.io/v1beta1 | |||
kind: DockerMachineTemplate | |||
metadata: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just moved this down as it's the more logical order and to make it easy to diff against (and thus keep in sync with) the ClusterClass
Signed-off-by: Stefan Büringer [email protected]
a1a2c35
to
9693613
Compare
/assign @fabriziopandini |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Stefan Büringer [email protected]
What this PR does / why we need it:
More context in the issue.
Tested manually against a tilt-managed cluster (envsubst'ed cluster-template manually + kubectl apply)
Note: The KCPTemplate is only valid after #5788 has been merged.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #5730