Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 move capd packages to internal #5795

Merged
merged 1 commit into from
Dec 7, 2021
Merged

🌱 move capd packages to internal #5795

merged 1 commit into from
Dec 7, 2021

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:
Move CAPD packages not intended for public usage to internal

  • /test/infrastructure/docker/cloudinit --> /test/infrastructure/docker/internal/cloudinit
  • /test/infrastructure/docker/docker --> /test/infrastructure/docker/internal/docker
  • /test/infrastructure/docker/third_party --> /test/infrastructure/docker/internal/third_party
  • /test/infrastructure/docker/exp/docker --> /test/infrastructure/docker/exp/internal/docker

Which issue(s) this PR fixes:
Rif ##5455

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 6, 2021
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 6, 2021
@fabriziopandini fabriziopandini force-pushed the move-capd-packages-to-internal branch from f6f9b3b to 1caf66c Compare December 6, 2021 14:01
@fabriziopandini fabriziopandini changed the title move capd packages to internal 🌱 move capd packages to internal Dec 6, 2021
@fabriziopandini
Copy link
Member Author

/retest

sbueringer
sbueringer reviewed Dec 6, 2021
View reviewed changes
Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise lgtm

test/infrastructure/docker/internal/controllers/dockermachine_controller.go Outdated Show resolved Hide resolved
test/infrastructure/docker/internal/docker/loadbalancer.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 6, 2021
@fabriziopandini fabriziopandini force-pushed the move-capd-packages-to-internal branch from 1caf66c to bfb9108 Compare December 7, 2021 17:20
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 7, 2021
@sbueringer
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 7, 2021
@sbueringer
Copy link
Member

Needs top-level approval :)

@CecileRobertMichon
Copy link
Contributor

/retest
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 7, 2021
@k8s-ci-robot k8s-ci-robot merged commit faffa2c into kubernetes-sigs:main Dec 7, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.1 milestone Dec 7, 2021
@fabriziopandini fabriziopandini deleted the move-capd-packages-to-internal branch December 13, 2021 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbueringer sbueringer sbueringer left review comments

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

Assignees

@sbueringer sbueringer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.1
Development

Successfully merging this pull request may close these issues.
4 participants
@fabriziopandini @sbueringer @CecileRobertMichon @k8s-ci-robot