Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix adding appended list directly causing changing previous value #5765

Merged
merged 1 commit into from
Dec 1, 2021
Merged

🐛 Fix adding appended list directly causing changing previous value #5765

merged 1 commit into from
Dec 1, 2021

Conversation

k8s-infra-cherrypick-robot
Copy link

This is an automated cherry-pick of #5670

/assign fabriziopandini

@yongxiu
Fix adding appended list directly causing changing previous value
347b9eb 
* Added new unit test to cover this case, original this test case would fail.
@k8s-ci-robot k8s-ci-robot added this to the v1.0 milestone Dec 1, 2021
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Dec 1, 2021
Merged
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 1, 2021
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 1, 2021
@sbueringer
Copy link
Member

/retitle 🐛 Fix adding appended list directly causing changing previous value #5765

/lgtm

@k8s-ci-robot k8s-ci-robot changed the title [release-1.0] 🐛 Fix adding appended list directly causing changing previous value 🐛 Fix adding appended list directly causing changing previous value #5765 Dec 1, 2021
@sbueringer
Copy link
Member

/retitle 🐛 Fix adding appended list directly causing changing previous value

@k8s-ci-robot k8s-ci-robot changed the title 🐛 Fix adding appended list directly causing changing previous value #5765 🐛 Fix adding appended list directly causing changing previous value Dec 1, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 1, 2021
vincepri
vincepri approved these changes Dec 1, 2021
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 1, 2021
@k8s-ci-robot k8s-ci-robot merged commit 89db44e into kubernetes-sigs:release-1.0 Dec 1, 2021
@fabriziopandini
Copy link
Member

/cherry-pick release-0.4

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Dec 20, 2021
Merged
@k8s-infra-cherrypick-robot
Copy link
Author

@fabriziopandini: new pull request created: #5876

In response to this:

/cherry-pick release-0.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@g-gaston g-gaston mentioned this pull request Jan 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincepri vincepri vincepri approved these changes

@enxebre enxebre Awaiting requested review from enxebre

@stmcginnis stmcginnis Awaiting requested review from stmcginnis

Assignees

@vincepri vincepri

@sbueringer sbueringer

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.
6 participants
@k8s-infra-cherrypick-robot @sbueringer @k8s-ci-robot @fabriziopandini @vincepri @yongxiu